Skip to content

Conversation

sighingnow
Copy link
Collaborator

@sighingnow sighingnow commented Jul 22, 2025

…en 1m models.

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Fixes a bug in the DCA backend. The error was introduced during rebasing previous PR: #11844

@mergify mergify bot added the qwen Related to Qwen models label Jul 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the dual-chunk-flash-attention backend for Qwen 1M models. The changes involve removing an erroneous block_table parameter from several function calls within vllm/attention/backends/dual_chunk_flash_attn.py. My review confirms that this parameter was being passed incorrectly to functions that expect contiguous tensors, and its removal is the correct fix. The changes are consistent and well-contained, resolving the bug introduced during a previous rebase. The code quality is good.

@noooop
Copy link
Collaborator

noooop commented Jul 22, 2025

@sighingnow

Please help verify whether using VLLM_ALLOW_LONG_MAX_MODEL_LEN in examples/offline_inference/qwen_1m.py may potentially cause issues leading to nan.

Refer to #20904

…en 1m models.

I didn't even know what kind of machine could run it
And I'm not familiar with the dual-chunk-flash-attention backend either.

Nan can cause the detokener to output !!!!!!!!!!!!!!
very easy to verify.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@sighingnow
Copy link
Collaborator Author

@sighingnow

Please help verify whether using VLLM_ALLOW_LONG_MAX_MODEL_LEN in examples/offline_inference/qwen_1m.py may potentially cause issues leading to nan.

Refer to #20904

…en 1m models.

I didn't even know what kind of machine could run it And I'm not familiar with the dual-chunk-flash-attention backend either.

Nan can cause the detokener to output !!!!!!!!!!!!!! very easy to verify.

This issue should be orthogonal with this PR. I will take a look, but could we merge this PR first to make qwen-1m work?

@youkaichao
Copy link
Member

cc @LucasWilkinson

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving since @sighingnow maintains the dual-chunk attention thing and this change looks reasonable.

@youkaichao youkaichao added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 23, 2025
@sighingnow
Copy link
Collaborator Author

LGTM, approving since @sighingnow maintains the dual-chunk attention thing and this change looks reasonable.

Thanks! The failed test looks not caused by this PR.

@simon-mo simon-mo merged commit 7c734ee into vllm-project:main Jul 23, 2025
66 of 68 checks passed
zixi-qi pushed a commit to zixi-qi/vllm that referenced this pull request Jul 23, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants