Skip to content

[Bugfix][TPU] Use np array when updating cache slot_mapping #17971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

[Bugfix][TPU] Use np array when updating cache slot_mapping #17971

merged 1 commit into from
May 12, 2025

Conversation

lsy323
Copy link
Collaborator

@lsy323 lsy323 commented May 11, 2025 •
edited by github-actions bot
Loading

Fix a typo in #17483

The in-place np.add will throw an error if the output placeholder is not np array.

cc @heheda12345 @WoosukKwon @mgoin

@lsy323
fix a bug in runner
761020a 
Signed-off-by: Siyuan Liu <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added v1 tpu Related to Google TPUs labels May 11, 2025
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label May 11, 2025
@DarkLight1337 DarkLight1337 merged commit 4307830 into vllm-project:main May 12, 2025
89 checks passed
This was referenced May 12, 2025
Closed
Closed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@lsy323
[Bugfix][TPU] Use np array when updating cache slot_mapping (vllm-pro…
303e6e4 
…ject#17971)

Signed-off-by: Siyuan Liu <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@lsy323 @mawong-amd
[Bugfix][TPU] Use np array when updating cache slot_mapping (vllm-pro…
06440c5 
…ject#17971)

Signed-off-by: Siyuan Liu <[email protected]>
@NickLucche NickLucche mentioned this pull request May 15, 2025
Closed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@lsy323
[Bugfix][TPU] Use np array when updating cache slot_mapping (vllm-pro…
fc5fe48 
…ject#17971)

Signed-off-by: Siyuan Liu <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

@njhill njhill Awaiting requested review from njhill

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsy323 @mgoin @DarkLight1337