Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented May 8, 2025

  • Broadcast Ovis2 implementation to fit Ovis1.5 and Ovis1.6

Update:
Ovis1.5's image processing and ViT implementation are quite different from Ovis2 and Ovis1.6, it needs much more extra effort to refactor existing ViT and processor. I decided to leave it to be done in a following PR to avoid blocking Ovis1.6 landing.

FIX #8972
FIX #9638

Copy link

github-actions bot commented May 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label May 8, 2025
@mergify mergify bot added the frontend label May 8, 2025
Signed-off-by: Isotr0py <[email protected]>
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label May 8, 2025
Isotr0py added 4 commits May 9, 2025 00:20
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py changed the title [Model] Broadcast Ovis2 implementation to fit Ovis1.5 and Ovis1.6 [Model] Broadcast Ovis2 implementation to fit Ovis1.6 May 9, 2025
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py Isotr0py marked this pull request as ready for review May 9, 2025 17:01
Isotr0py added 2 commits May 10, 2025 01:31
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, assuming that you have tested the model already

@Isotr0py Isotr0py enabled auto-merge (squash) May 11, 2025 16:11
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 11, 2025
@vllm-bot vllm-bot merged commit 021c16c into vllm-project:main May 12, 2025
63 of 68 checks passed
@Isotr0py Isotr0py deleted the ovis branch May 12, 2025 04:52
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New Model]: Ovis1.6-Gemma2-9B [New Model]: Add support for Ovis models

3 participants