-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[BugFix] [ROCm]: Bugfix and handle addition case of input for rocm_aiter_rms_norm
#17857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: tjtanaa <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: tjtanaa <[email protected]>
| residual_out = torch.empty_like(residual) | ||
| output = torch.empty_like(x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wasn't this copy necessary before? Would making the copy conditional improve performance in cases where a copy isn't required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DarkLight1337 It is a bugfix of using the AITER commit: 5a77249 . The usage of the ops has changed at some point. However, it hasn't been throwing error in any of the unit tests. To ensure the correctness, we have followed the usage of the kernel based on this commit 5a77249 specifically.
…iter_rms_norm` (vllm-project#17857) Signed-off-by: tjtanaa <[email protected]> Signed-off-by: Mu Huai <[email protected]>
…iter_rms_norm` (vllm-project#17857) Signed-off-by: tjtanaa <[email protected]>
…iter_rms_norm` (vllm-project#17857) Signed-off-by: tjtanaa <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
After this PR (#17735) , a new case to be handled in
rocm_aiter_rms_norm.xcould be a 3-dimensional tensor.xis reshaped to 2-dimensional tensors before callingaiter.rms_normlm_eval
Dataset: GSM8K
Engine: V0
Qwen/Qwen3-235B-A22B-FP8 without AITER
vllm (pretrained=Qwen/Qwen3-235B-A22B-FP8,tensor_parallel_size=4,max_model_len=10000,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
Qwen/Qwen3-235B-A22B-FP8 with AITER RMS Norm
vllm (pretrained=Qwen/Qwen3-235B-A22B-FP8,tensor_parallel_size=4,max_model_len=10000,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
Qwen/Qwen3-32B without AITER
vllm (pretrained=Qwen/Qwen3-32B,tensor_parallel_size=1,max_model_len=10000,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
Qwen/Qwen3-32B with AITER RMS Norm
vllm (pretrained=Qwen/Qwen3-32B,tensor_parallel_size=4,max_model_len=10000,trust_remote_code=True), gen_kwargs: (None), limit: None, num_fewshot: 5, batch_size: auto
Add Qwen3 dense to the list of
test_common.pyPassed:
tests/models/language/generation/test_common.py