Skip to content

Improve configs - ObservabilityConfig #17453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2025
Merged

Improve configs - ObservabilityConfig #17453

merged 3 commits into from
May 1, 2025
+96 −66

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Apr 30, 2025

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337
DarkLight1337 reviewed Apr 30, 2025
View reviewed changes
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 30, 2025
@hmellor
Remove deprecation
50e2e5b 
Signed-off-by: Harry Mellor <[email protected]>
@mergify
Copy link

mergify bot commented Apr 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @hmellor.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 30, 2025
@mergify mergify bot removed the needs-rebase label May 1, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 1, 2025 08:22
@vllm-bot vllm-bot merged commit a257d9b into vllm-project:main May 1, 2025
44 of 48 checks passed
@hmellor hmellor deleted the improve-observability-config branch May 1, 2025 11:54
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
@hmellor @radeksm
Improve configs - ObservabilityConfig (vllm-project#17453)
b4277f5 
Signed-off-by: Harry Mellor <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Improve configs - ObservabilityConfig (vllm-project#17453)
9d581bc 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Improve configs - ObservabilityConfig (vllm-project#17453)
d89a110 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmellor @DarkLight1337 @vllm-bot