Skip to content

Conversation

@russellb
Copy link
Member

@russellb russellb commented Apr 29, 2025

In PR #17259, the license specification in pyproject.toml was updated
to use the new format specified by PEP 639. The previous format has been
deprecated. Support for this new format requires setuptools>=77.0.3.
Update the requirements accordingly.

For more details on the format, see:
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

Signed-off-by: Russell Bryant [email protected]

FIX #17464

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Apr 29, 2025
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 29, 2025
@mergify
Copy link

mergify bot commented Apr 30, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 30, 2025
In PR vllm-project#17259, the license specification in `pyproject.toml` was updated
to use the new format specified by PEP 639. The previous format has been
deprecated. Support for this new format requires `setuptools>=77.0.3`.
Update the requirements accordingly.

For more details on the format, see:
https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license

Signed-off-by: Russell Bryant <[email protected]>
Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb force-pushed the fix-pyproject-license branch from 7da34ac to 68b7575 Compare April 30, 2025 14:26
@mergify mergify bot removed the needs-rebase label Apr 30, 2025
@DarkLight1337
Copy link
Member

Just upgrading setuptools doesn't update the packaging version, so that has to be set explicitly as well

Signed-off-by: Russell Bryant <[email protected]>
@russellb
Copy link
Member Author

Just upgrading setuptools doesn't update the packaging version, so that has to be set explicitly as well

Sorry about that! I read the comments too fast before the last update. It should have the packaging update now, too.

@vllm-bot vllm-bot merged commit 7a0a146 into vllm-project:main May 1, 2025
72 of 74 checks passed
radeksm pushed a commit to radeksm/vllm that referenced this pull request May 2, 2025
EduardDurech pushed a commit to swiss-ai/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
bkueng added a commit to PX4/pyulog that referenced this pull request Jul 9, 2025
bkueng added a commit to PX4/pyulog that referenced this pull request Jul 10, 2025
WSH032 added a commit to pytauri/pytauri that referenced this pull request Aug 4, 2025
github-merge-queue bot pushed a commit to pytauri/pytauri that referenced this pull request Aug 11, 2025
* feat: support registering plugin from python

* feat: add `clipboard-manager` plugin

* feat: add `fs` plugin

* feat: add `opener` plugin

* feat: better error handling

* refactor: move `BoxedPluginWrapper` behind `__private` feature gate

* refactor: bump `tauri` monorepo and use new `plugin_boxed` api

* feat: add `autostart` plugin

* feat: add `deep-link` plugin

* feat: add `http` plugin

* feat: add `os` plugin

* feat: add `persisted-scope` plugin

* feat: add `positioner` plugin

* feat: add `process` plugin

* feat: add `shell` plugin

* feat: add `single-instance` plugin

* feat: add `updater` plugin

* feat: add `upload` plugin

* feat: add `websocket` plugin

* feat: add `window-state` plugin

* feat: add `global-shortcut` plugin

* feat(pytauri-wheel)!: use new `pytauri.BuilderArgs.plugins` api

bump `setuptools >= 77.0.3` for PEP 639, see <vllm-project/vllm#17389>

* build: downgrade `setuptools-scm` to 8.* to fix build error

see <https://github.com/pytauri/pytauri/actions/runs/16721825221/job/47327792333?pr=220#step:13:151>

* build(docs): downgrade `git-revision-date-localized` to `1.3.*`

Because `1.4.*` is very slow,
see <timvink/mkdocs-git-revision-date-localized-plugin#181>

* chore: add `yaml.customTags` to resolve `mkdocs.yml` schema error

See:
- <https://squidfunk.github.io/mkdocs-material/creating-your-site/#minimal-configuration-visual-studio-code>
- <redhat-developer/vscode-yaml#238 (comment)>

* build(docs): add `ENABLE_MKDOCSTRINGS` env var to reduce dev build time

* style(rust): fix `1.89` clippy warning

* docs: add docs for `tutorial/using_plugins` and `pytauri-wheel`

* docs: changelog

* docs(pytauri/docstring): fix wrong `tauri_plugin_clipboard_manager::init` link

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: configuration error: project.license must be valid exactly by one definition (2 matches found)

4 participants