-
-
Notifications
You must be signed in to change notification settings - Fork 11.6k
[Bugfix] Fix Mistral3 spatial merge error #17270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix Mistral3 spatial merge error #17270
Conversation
Signed-off-by: mgoin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
|
Thanks for debugging and fixing! |
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Signed-off-by: mgoin <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
FIX #16675
We just were not patching spatial_merge_size into the vision config in both of the places needed. This results in the dummy inputs having the right spatial_merge_size being applied but actual inferences were missing it, causing the shapes to mismatch during inference.
Here is where is it being applied already in vision.py
vllm/vllm/model_executor/models/vision.py
Lines 63 to 67 in 20e489e
With this PR, the example passes: