Skip to content

[Misc] Validate stop_token_ids contents #17268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

[Misc] Validate stop_token_ids contents #17268

merged 1 commit into from
Apr 28, 2025

Conversation

@njhill
Copy link
Member

@njhill njhill commented Apr 27, 2025 •
edited by DarkLight1337
Loading

FIX #16782 (comment)

Ensure stop_token_ids only contains ints to avoid errors within the engine.

@njhill
[Misc] Validate stop_token_ids contents
ba6e6e8 
Ensure stop_token_ids only contains ints to avoid errors within the engine.

Signed-off-by: Nick Hill <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 27, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill njhill mentioned this pull request Apr 27, 2025
Closed
1 task
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 28, 2025 02:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 28, 2025
@DarkLight1337
Copy link
Member

DarkLight1337 commented Apr 28, 2025

Thanks for fixing!

@DarkLight1337 DarkLight1337 merged commit 8262a3e into vllm-project:main Apr 28, 2025
62 checks passed
@njhill njhill deleted the validate-stop-ids branch April 28, 2025 14:56
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@njhill @dbyoung18
[Misc] Validate stop_token_ids contents (vllm-project#17268)
f5d9c6e 
Signed-off-by: Nick Hill <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@njhill @lk-chen
[Misc] Validate stop_token_ids contents (vllm-project#17268)
4b3d449 
Signed-off-by: Nick Hill <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@njhill @adobrzyn
[Misc] Validate stop_token_ids contents (vllm-project#17268)
3dcb749 
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@njhill
[Misc] Validate stop_token_ids contents (vllm-project#17268)
a2756ca 
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@njhill
[Misc] Validate stop_token_ids contents (vllm-project#17268)
f9d6dca 
Signed-off-by: Nick Hill <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: InternVL3-9B call is hanging

2 participants

@njhill @DarkLight1337