Skip to content

[MISC][AMD] Add unused annotation to rocm kernel file #17097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2025
Merged

[MISC][AMD] Add unused annotation to rocm kernel file #17097

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions csrc/rocm/skinny_gemms.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ __global__ void LLGemm1_kernel(const scalar_t* in_a, const scalar_t* in_b,
colB_elem4w = bf4[threadid * 4 + 3];

scalar2_t Af2;
scalar2_t Bf2;
[[maybe_unused]] scalar2_t Bf2;
Copy link
Collaborator

@hongxiayang hongxiayang Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad Good catch (thumb up to the tool which found this). It looks to me that it is safe to remove the unused variable.
@WoosukKwon vllm should enable this tool in the pre-commit check

Copy link
Collaborator

@hongxiayang hongxiayang Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[maybe_unused]] scalar2_t Bf2;

Copy link
Collaborator

@hongxiayang hongxiayang Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @charlifu

float2 S;

auto Ah2ptr = reinterpret_cast<scalar2_t*>(&rowA_elem4);
Expand Down Expand Up @@ -1597,4 +1597,4 @@ void wvSplitKQ(at::Tensor& in_a, at::Tensor& in_b, at::Tensor& out_c,
}
});
});
}
}