Skip to content

[Misc] Update outdated note: LMCache now supports chunked prefill #16697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

[Misc] Update outdated note: LMCache now supports chunked prefill #16697

merged 1 commit into from
Apr 18, 2025

Conversation

chaunceyjiang
Copy link
Collaborator

FIX #16452

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 16, 2025
@jeejeelee jeejeelee requested a review from KuntaiDu April 16, 2025 08:18
mgoin
mgoin approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mgoin
Copy link
Member

mgoin commented Apr 17, 2025

Actually looks like you have merge conflict to resolve first

@mergify Mergify
Copy link

mergify bot commented Apr 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @chaunceyjiang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Apr 17, 2025
@mergify mergify bot removed the needs-rebase label Apr 17, 2025
@chaunceyjiang
Copy link
Collaborator Author

Actually looks like you have merge conflict to resolve first

@mgoin Done.

@chaunceyjiang
Copy link
Collaborator Author

Hi, @DarkLight1337 Can you help me try e2e again?

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 18, 2025 04:24
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 18, 2025
@DarkLight1337 DarkLight1337 merged commit 7a4a5de into vllm-project:main Apr 18, 2025
39 of 41 checks passed
@chaunceyjiang chaunceyjiang deleted the issue_16452 branch April 18, 2025 06:02
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@chaunceyjiang @yangw-dev
[Misc] Update outdated note: LMCache now supports chunked prefill (vl…
35bafc3 
…lm-project#16697)

Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@chaunceyjiang @dbyoung18
[Misc] Update outdated note: LMCache now supports chunked prefill (vl…
1a6f896 
…lm-project#16697)

Signed-off-by: chaunceyjiang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@chaunceyjiang @lk-chen
[Misc] Update outdated note: LMCache now supports chunked prefill (vl…
1abe25a 
…lm-project#16697)

Signed-off-by: chaunceyjiang <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@chaunceyjiang @adobrzyn
[Misc] Update outdated note: LMCache now supports chunked prefill (vl…
0c2fadd 
…lm-project#16697)

Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@chaunceyjiang
[Misc] Update outdated note: LMCache now supports chunked prefill (vl…
19fa885 
…lm-project#16697)

Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@KuntaiDu KuntaiDu Awaiting requested review from KuntaiDu

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Doc]: Update outdated note: LMCache now supports chunked prefill

3 participants

@chaunceyjiang @mgoin @DarkLight1337