Skip to content

Conversation

sarckk
Copy link
Collaborator

@sarckk sarckk commented Apr 11, 2025

Attention temperature tuning (on nope layers) improves accuracy on long context (>32k) tasks. Enabling it by default for long context unless explicitly disabled by the user.

Eval results on RULER with and without attention temperature tuning (@luccafong):

Screenshot 2025-04-10 at 17 31 37

cc: @ywang96 @simon-mo @DarkLight1337

@sarckk sarckk requested a review from houseroad April 11, 2025 00:42
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yeqcharlotte
Copy link
Collaborator

we probably need to update blog accordingly and tell users how to disable instead lol also cc: @astonzhang

Copy link
Collaborator

@yeqcharlotte yeqcharlotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the evals!

Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 11, 2025
@vllm-bot vllm-bot merged commit 99ef59c into vllm-project:main Apr 11, 2025
59 of 63 checks passed
luccafong added a commit to luccafong/vllm-project.github.io that referenced this pull request Apr 15, 2025
Since we auto-enable this with max-model-len > 32 in PR vllm-project/vllm#16439, this tip can be removed to avoid confusion.
simon-mo pushed a commit to vllm-project/vllm-project.github.io that referenced this pull request Apr 15, 2025
Since we auto-enable this with max-model-len > 32 in PR vllm-project/vllm#16439, this tip can be removed to avoid confusion.
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
…ext (>32k) (vllm-project#16439)

Signed-off-by: Ye (Charlotte) Qi <[email protected]>
Co-authored-by: Ye (Charlotte) Qi <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
…ext (>32k) (vllm-project#16439)

Signed-off-by: Ye (Charlotte) Qi <[email protected]>
Co-authored-by: Ye (Charlotte) Qi <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
…ext (>32k) (vllm-project#16439)

Signed-off-by: Ye (Charlotte) Qi <[email protected]>
Co-authored-by: Ye (Charlotte) Qi <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
…ext (>32k) (vllm-project#16439)

Signed-off-by: Ye (Charlotte) Qi <[email protected]>
Co-authored-by: Ye (Charlotte) Qi <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants