Skip to content

Conversation

@mgoin
Copy link
Member

@mgoin mgoin commented Apr 10, 2025

Fix due to #16291, we needed to actually import SamplingParams rather than just using it for TYPE_CHECKING

Without this change you hit this error when making a request on TPU in V1

  File "/home/mgoin/code/vllm/vllm/v1/engine/processor.py", line 186, in process_inputs
    current_platform.validate_request(
  File "/home/mgoin/code/vllm/vllm/platforms/tpu.py", line 157, in validate_request
    if isinstance(params,
       ^^^^^^^^^^^^^^^^^^
TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union

Signed-off-by: Michael Goin <[email protected]>
@mgoin mgoin changed the title Fix TPU validate_request vall Fix TPU validate_request Apr 10, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the tpu Related to Google TPUs label Apr 10, 2025
@mgoin mgoin added bug Something isn't working v1 labels Apr 10, 2025
@mgoin mgoin requested a review from joerunde April 10, 2025 00:41
@mgoin mgoin changed the title Fix TPU validate_request [Bugfix][TPU] Fix TPU validate_request Apr 10, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 10, 2025 02:12
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 10, 2025
@DarkLight1337 DarkLight1337 disabled auto-merge April 10, 2025 02:15
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgoin

cc @joerunde

@DarkLight1337 DarkLight1337 merged commit baada0e into vllm-project:main Apr 10, 2025
63 of 66 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants