-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[Bugfix][TPU] Fix TPU validate_request #16369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][TPU] Fix TPU validate_request #16369
Conversation
Signed-off-by: Michael Goin <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
njhill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Michael Goin <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Michael Goin <[email protected]>
Signed-off-by: Michael Goin <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Fix due to #16291, we needed to actually import SamplingParams rather than just using it for TYPE_CHECKING
Without this change you hit this error when making a request on TPU in V1