Skip to content

Conversation

MarcCote
Copy link
Contributor

@MarcCote MarcCote commented Mar 19, 2025

This PR updates the following tip info under the Use vLLM’s Official Docker Image section of the docs.

image

There is no need for --system when updating the Python installation is already managed by uv (according to this astral-sh/uv#12204 (comment)).

When running with --system I was getting this error:

[+] Building 7.8s (5/6)                                                                                                                                                                                                        docker:default
 => [internal] load build definition from dockerfile                                                                                                                                                                                     0.4s
 => => transferring dockerfile: 215B                                                                                                                                                                                                     0.0s
 => [internal] load metadata for docker.io/vllm/vllm-openai:v0.8.0                                                                                                                                                                       0.0s 
 => [internal] load .dockerignore                                                                                                                                                                                                        0.3s 
 => => transferring context: 2B                                                                                                                                                                                                          0.0s 
 => [1/3] FROM docker.io/vllm/vllm-openai:v0.8.0                                                                                                                                                                                         4.7s 
 => ERROR [2/3] RUN uv pip install --system git+https://github.com/huggingface/transformers.git                                                                                                                                          1.5s 
------                                                                                                                                                                                                                                        
 > [2/3] RUN uv pip install --system git+https://github.com/huggingface/transformers.git:                                                                                                                                                     
1.230 error: No system Python installation found                                                                                                                                                                                              
------                                                                                                                                                                                                                                        
dockerfile:3                                                                                                                                                                                                                                  
--------------------                                                                                                                                                                                                                          
   1 |     FROM vllm/vllm-openai:v0.8.0                                                                                                                                                                                                       
   2 |                                                                                                                                                                                                                                        
   3 | >>> RUN uv pip install --system git+https://github.com/huggingface/transformers.git

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Mar 19, 2025
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Can you update the other example dockerfile as well?

@MarcCote
Copy link
Contributor Author

MarcCote commented Mar 19, 2025

Thanks for fixing! Can you update the other example dockerfile as well?

You are talking about this example?

FROM vllm/vllm-openai:v0.7.3

# e.g. install the `audio` and `video` optional dependencies
# NOTE: Make sure the version of vLLM matches the base image!
RUN uv pip install --system vllm[audio,video]==0.7.3

If so, I believe in vllm/vllm-openai:v0.7.3 the Python installation is not managed by uv, that's why it needs --system. That change happened ~2 weeks in #13569

Edit: let me know if you want me to change v0.7.3 for v0.8.0 in that example, instead.

No need for --system when updating a Python installation already managed by uv.
@MarcCote
Copy link
Contributor Author

Actually, I went ahead and made the version change. That seems like the right thing to do, anyway. I have tested both examples locally and they worked for me.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 19, 2025 12:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2025
@DarkLight1337 DarkLight1337 merged commit 073d1ed into vllm-project:main Mar 19, 2025
16 of 19 checks passed
@nickhelion
Copy link

I tried the sample without --system below

FROM vllm/vllm-openai:latest

RUN uv pip install vllm[audio,video]

and it gives

> ERROR [2/2] RUN uv pip install vllm[audio,video]                                                                                   0.3s 
------
 > [2/2] RUN uv pip install vllm[audio,video]:
0.330 error: No virtual environment found; run `uv venv` to create an environment, or pass `--system` to install into a non-virtual environment
------
--------------------
   1 |     FROM vllm/vllm-openai:latest
   2 |
   3 | >>> RUN uv pip install vllm[audio,video]
   4 |
--------------------
ERROR: failed to solve: process "/bin/sh -c uv pip install vllm[audio,video]" did not complete successfully: exit code: 2

putting it back solved the issue.
Maybe the vllm/vllm:latest i pulled today is not actually the latest?

@DarkLight1337
Copy link
Member

--system is now needed again because #13569 got reverted due to breaking a bunch of deployments

@DarkLight1337
Copy link
Member

The docs have been updated in #15616

lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants