-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Doc] Update tip info on using latest transformers when creating a custom Dockerfile #15070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Can you update the other example dockerfile as well?
You are talking about this example? FROM vllm/vllm-openai:v0.7.3
# e.g. install the `audio` and `video` optional dependencies
# NOTE: Make sure the version of vLLM matches the base image!
RUN uv pip install --system vllm[audio,video]==0.7.3 If so, I believe in Edit: let me know if you want me to change |
No need for --system when updating a Python installation already managed by uv.
Actually, I went ahead and made the version change. That seems like the right thing to do, anyway. I have tested both examples locally and they worked for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, thanks!
I tried the sample without
and it gives
putting it back solved the issue. |
|
The docs have been updated in #15616 |
…stom Dockerfile (vllm-project#15070) Signed-off-by: Louis Ulmer <[email protected]>
…stom Dockerfile (vllm-project#15070) Signed-off-by: Mu Huai <[email protected]>
This PR updates the following tip info under the Use vLLM’s Official Docker Image section of the docs.
There is no need for
--system
when updating the Python installation is already managed by uv (according to this astral-sh/uv#12204 (comment)).When running with
--system
I was getting this error: