-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Attention] Remove slow setattr in MLA #14769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Attention] Remove slow setattr in MLA #14769
Conversation
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
if self.cos_sin_cache.device != query.device or \ | ||
self.cos_sin_cache.dtype != query.dtype: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been curious about this for a long time. when will this condition be false? i.e. the query
has different device / dtype from the cos_sin_cache
.
Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Richard Liu <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Partial undo of #14471 which was a revert of #14384