Skip to content

[BugFix]Fix performance serving benchmark when enable profiling #14737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

[BugFix]Fix performance serving benchmark when enable profiling #14737

merged 1 commit into from
Mar 14, 2025

Conversation

Potabk
Copy link
Contributor

@Potabk Potabk commented Mar 13, 2025 •
edited by github-actions bot
Loading

Fix the endpoint assertion to enable profiling , #14036

@Potabk
enable profiling
e911631 
Signed-off-by: wangli <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@JenZhao
Copy link
Contributor

JenZhao commented Mar 13, 2025

cc @ywang96

ywang96
ywang96 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 14, 2025
@ywang96 ywang96 enabled auto-merge (squash) March 14, 2025 05:15
@ywang96 ywang96 merged commit 09269b3 into vllm-project:main Mar 14, 2025
29 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
@Potabk @richardsliu
[BugFix]Fix performance serving benchmark when enable profiling (vllm…
a4f2d9e 
…-project#14737)

Signed-off-by: wangli <[email protected]>
Signed-off-by: Richard Liu <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Potabk @lulmer
[BugFix]Fix performance serving benchmark when enable profiling (vllm…
ab0c384 
…-project#14737)

Signed-off-by: wangli <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Potabk @shreyankg
[BugFix]Fix performance serving benchmark when enable profiling (vllm…
7bffed1 
…-project#14737)

Signed-off-by: wangli <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Potabk
[BugFix]Fix performance serving benchmark when enable profiling (vllm…
6550d58 
…-project#14737)

Signed-off-by: wangli <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Potabk @JenZhao @ywang96