Skip to content

Conversation

wyajieha
Copy link
Contributor

@wyajieha wyajieha commented Mar 7, 2025

Fix AllSpark kernel compilation errors and enable kernel for CUDA version < 12.0. (As mentioned in #14157 and #12931 (comment))

@wyajieha wyajieha requested a review from tlrmchlsmth as a code owner March 7, 2025 10:26
Copy link

github-actions bot commented Mar 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 7, 2025
@wyajieha wyajieha changed the title [Bugfix]: Fix AllSpark kernel compilation errors and enable for CUDA < 12.0 [Bugfix][Kernel]: Fix AllSpark kernel compilation errors and enable for CUDA < 12.0 Mar 7, 2025
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 9, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled CI, let's see if the CUDA 11.8 build passes now. Thank you @wyajieha!

@wyajieha
Copy link
Contributor Author

Hi, @mgoin ,the CI test failed due to issues related to the docker image. Should we re-trigger the pipeline?

@mgoin
Copy link
Member

mgoin commented Mar 12, 2025

Hi, I already retried and it failed again. Maybe you could merge with latest main and see if that helps?

@wyajieha
Copy link
Contributor Author

wyajieha commented Mar 13, 2025

Hi, @mgoin , I've merged the latest main branch, but some new unrelated CI tests are failing (doesn't seem connected to this PR).

@vllm-bot vllm-bot merged commit 977a167 into vllm-project:main Mar 14, 2025
51 of 56 checks passed
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Mar 14, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants