Skip to content

Conversation

MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented Feb 28, 2025

Mainly changes

  1. Move use_all_gather to platform so that the oot devices could override it instead of modifying in vLLM
  2. Add check of sampling_metadata.seq_groups before applying logits processor, as when using all-gather, the logits is not none, but sampling_metadata.seq_groups is none, so _apply_logits_processors will raise an unexpected error. We add this check to avoid step into _apply_logits_processors when using all-gather

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@MengqingCao
Copy link
Contributor Author

@youkaichao could you help review this? thx!

@wangxiyuan wangxiyuan mentioned this pull request Mar 3, 2025
1 task
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@youkaichao youkaichao enabled auto-merge (squash) March 3, 2025 05:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 3, 2025
@MengqingCao
Copy link
Contributor Author

CI failed due to network issue

@youkaichao youkaichao disabled auto-merge March 3, 2025 07:39
@youkaichao youkaichao merged commit b87c21f into vllm-project:main Mar 3, 2025
46 of 49 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants