Skip to content

Fix failing MyGemma2Embedding test #13820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix failing MyGemma2Embedding test #13820

merged 2 commits into from
Feb 25, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Feb 25, 2025 •
edited by github-actions bot
Loading

Follow up for #13555

@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 25, 2025
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 25, 2025 09:52
@simon-mo simon-mo disabled auto-merge February 25, 2025 20:32
@simon-mo simon-mo merged commit 34e3494 into vllm-project:main Feb 25, 2025
13 of 14 checks passed
@hmellor hmellor deleted the fix-gemma-test branch February 25, 2025 20:33
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@hmellor @Akshat-Tripathi
Fix failing MyGemma2Embedding test (vllm-project#13820)
e78fc4b 
Signed-off-by: Harry Mellor <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@hmellor @lulmer
Fix failing MyGemma2Embedding test (vllm-project#13820)
b3cfb73 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@hmellor @shreyankg
Fix failing MyGemma2Embedding test (vllm-project#13820)
335729c 
Signed-off-by: Harry Mellor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmellor @DarkLight1337 @simon-mo