-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[V1][Core] Porting Connector API to V1 #13385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @YuhanLiu11, thanks for submitting the PR. Unfortunately, we're currently focused on a few other higher-priority items in V1, so we need to hold off on any other changes until those are resolved. This may take 2-4 weeks. I will get back to this PR after that. Thanks for understanding.
Got it! Thanks for the information. |
This pull request has merge conflicts that must be resolved before it can be |
@YuhanLiu11 Just wondering: |
I agree with @orozery, giving Providing only input_tokens seems like a downgrade for custom connectors. |
@YuhanLiu11 I think you can close this PR. #15960 is the new one. |
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it. Thank you! |
This PR ports the connector API from V0: It introduces minimal changes to
gpu_model_runner.py
to send and receive KV caches through the connector.To see an example of how this connector API works in V1, run the disaggregated prefill script:
examples/online_serving/disaggregated_prefill_v1.sh
.Reference implementation: #8498