Skip to content

Conversation

YuhanLiu11
Copy link

@YuhanLiu11 YuhanLiu11 commented Feb 17, 2025

This PR ports the connector API from V0: It introduces minimal changes to gpu_model_runner.py to send and receive KV caches through the connector.

To see an example of how this connector API works in V1, run the disaggregated prefill script: examples/online_serving/disaggregated_prefill_v1.sh.

Reference implementation: #8498

Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
Signed-off-by: YuhanLiu11 <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Feb 17, 2025
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YuhanLiu11, thanks for submitting the PR. Unfortunately, we're currently focused on a few other higher-priority items in V1, so we need to hold off on any other changes until those are resolved. This may take 2-4 weeks. I will get back to this PR after that. Thanks for understanding.

@YuhanLiu11
Copy link
Author

Hi @YuhanLiu11, thanks for submitting the PR. Unfortunately, we're currently focused on a few other higher-priority items in V1, so we need to hold off on any other changes until those are resolved. This may take 2-4 weeks. I will get back to this PR after that. Thanks for understanding.

Got it! Thanks for the information.

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 28, 2025
Copy link

mergify bot commented Feb 28, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @YuhanLiu11.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 28, 2025
@KuntaiDu KuntaiDu self-assigned this Mar 9, 2025
@orozery
Copy link
Contributor

orozery commented Mar 18, 2025

@YuhanLiu11 Just wondering:
Why is the connector API changed to accept input_ids instead of model_input like in v0?
It seems to me that model_input is more flexible as it may allow for partial kv recv.

@hasB4K
Copy link
Contributor

hasB4K commented Mar 29, 2025

Why is the connector API changed to accept input_ids instead of model_input like in v0?

I agree with @orozery, giving model_inputs was better. One can for instance use the request_id by using list(model_inputs.request_ids_to_seq_ids.keys()) (it works since the dict keeps the order since Python 3.7).

Providing only input_tokens seems like a downgrade for custom connectors.

@hasB4K
Copy link
Contributor

hasB4K commented Apr 3, 2025

@YuhanLiu11 I think you can close this PR. #15960 is the new one.

Copy link

github-actions bot commented Jul 3, 2025

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale Over 90 days of inactivity label Jul 3, 2025
Copy link

github-actions bot commented Aug 2, 2025

This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it. Thank you!

@github-actions github-actions bot closed this Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation needs-rebase stale Over 90 days of inactivity v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants