Skip to content

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Jan 31, 2025

No description provided.

Signed-off-by: Roger Wang <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ywang96
Copy link
Member Author

ywang96 commented Jan 31, 2025

The code should already run with

VLLM_USE_V1=1 python3 examples/offline_inference/vision_language.py --model qwen2_5_vl

but there are a few more things to be fixed...

@ywang96 ywang96 marked this pull request as draft January 31, 2025 01:04
@yixqiao
Copy link

yixqiao commented Jan 31, 2025

Added a missing item for multi-modal tracker to enable chat API: https://github.com/yixqiao/vllm/tree/feature/qwen_2_5_vl

@ywang96
Copy link
Member Author

ywang96 commented Jan 31, 2025

Closing this in favor of #12604 for collaboration purposes

@ywang96 ywang96 closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants