Skip to content

Fix quantization for chatglm #12586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Fix quantization for chatglm #12586

wants to merge 5 commits into from

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Jan 30, 2025

No description provided.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@kylesayrs
additional prefix fixes
10908f6 
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs
use merged_proj
1ef97f0 
Signed-off-by: Kyle Sayers <[email protected]>
@mgoin mgoin marked this pull request as draft January 30, 2025 21:23
mgoin
mgoin commented Jan 30, 2025
View reviewed changes
@kylesayrs
Copy link
Contributor

Moved to #12634

@mgoin mgoin closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sighingnow sighingnow Awaiting requested review from sighingnow sighingnow will be requested when the pull request is marked ready for review sighingnow is a code owner

@22quinn 22quinn Awaiting requested review from 22quinn 22quinn will be requested when the pull request is marked ready for review 22quinn is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat will be requested when the pull request is marked ready for review robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth will be requested when the pull request is marked ready for review tlrmchlsmth is a code owner

@yewentao256 yewentao256 Awaiting requested review from yewentao256 yewentao256 will be requested when the pull request is marked ready for review yewentao256 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgoin @kylesayrs