Skip to content

Update pre-commit hooks #12475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2025
Merged

Update pre-commit hooks #12475

merged 4 commits into from
Jan 28, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Jan 27, 2025 •
edited by github-actions bot
Loading

The linting packages haven't been updated in a while, so I ran pre-commit autoupdate and fixed everything that does not comply with the latest versions of:

  • yapf
  • ruff
  • codespell
  • clang-format
  • pymarkdown

@hmellor
pre-commit autoupdate
f27327f 
Signed-off-by: Harry Mellor <[email protected]>
@hmellor
pre-commit run -a
1488aa2 
Signed-off-by: Harry Mellor <[email protected]>
@hmellor
pre-commit run -a
ccf79a8 
Signed-off-by: Harry Mellor <[email protected]>
@hmellor
Manual fixes
bdd3e66 
Signed-off-by: Harry Mellor <[email protected]>
@github-actions
Copy link

github-actions bot commented Jan 27, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

mgoin
mgoin approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csrc/moe/marlin_kernels/marlin_moe_kernel.h
Comment on lines -141 to +142
int lo = lop3<(0xf0 & 0xcc) | 0xaa>(q, LO, EX);
int hi = lop3<(0xf0 & 0xcc) | 0xaa>(q, HI, EX);
int lo = lop3 < (0xf0 & 0xcc) | 0xaa > (q, LO, EX);
int hi = lop3 < (0xf0 & 0xcc) | 0xaa > (q, HI, EX);
Copy link
Member

@mgoin mgoin Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree personally, but will accept it 🤕

Copy link
Member Author

@hmellor hmellor Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's as if the new version of clang-format is treating the template as comparison operators for the purpose of formatting 😕

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 27, 2025
@mgoin mgoin merged commit 823ab79 into vllm-project:main Jan 28, 2025
86 checks passed
@gaocegege
Copy link
Contributor

gaocegege commented Jan 28, 2025

Hi, I got this https://github.com/vllm-project/vllm/actions/runs/13001729148/job/36261547838?pr=12473#step:5:1268 after rebasing the main.

Is this from this PR?

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jan 28, 2025

Yes, should be fixed by #12494

tjtanaa pushed a commit to EmbeddedLLM/vllm that referenced this pull request Jan 28, 2025
@hmellor @tjtanaa
Update pre-commit hooks (vllm-project#12475)
0ae8f3e 
Signed-off-by: Harry Mellor <[email protected]>
rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
@hmellor @rasmith
Update pre-commit hooks (vllm-project#12475)
ad21728 
Signed-off-by: Harry Mellor <[email protected]>
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@hmellor @Isotr0py
Update pre-commit hooks (vllm-project#12475)
887f484 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@hmellor hmellor deleted the update-lint-packages branch February 6, 2025 08:16
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
@hmellor @NickLucche
Update pre-commit hooks (vllm-project#12475)
9b7e150 
Signed-off-by: Harry Mellor <[email protected]>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
@hmellor @GWS0428
Update pre-commit hooks (vllm-project#12475)
8fa297a 
Signed-off-by: Harry Mellor <[email protected]>
@yankay yankay mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

Assignees

No one assigned

Labels

ci/build frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmellor @gaocegege @DarkLight1337 @mgoin