-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
[CI/Build] Add sphinx/rst linter for docs #10366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
9b553ac
3508fe2
fb41d21
c4cd849
aaee36e
0ad8b0d
defdc21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,30 @@ | ||||||
name: Lint documentation | ||||||
|
||||||
on: | ||||||
push: | ||||||
branches: | ||||||
- main | ||||||
paths: | ||||||
- "docs/**" | ||||||
pull_request: | ||||||
branches: | ||||||
- main | ||||||
|
||||||
jobs: | ||||||
doc8: | ||||||
runs-on: ubuntu-latest | ||||||
strategy: | ||||||
matrix: | ||||||
python-version: ["3.12"] | ||||||
steps: | ||||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||||||
- name: Set up Python ${{ matrix.python-version }} | ||||||
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 | ||||||
with: | ||||||
python-version: ${{ matrix.python-version }} | ||||||
- name: Install dependencies | ||||||
run: | | ||||||
python -m pip install --upgrade pip | ||||||
pip install sphinx-lint | ||||||
|
pip install sphinx-lint | |
pip install -r requirements-lint.txt |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and I would change this to:
run: sphinx-lint docs | |
run: tools/sphinx-lint.sh |
This ensures that we use the same arguments to the tool for both CI and local usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason you have
paths
set for pushes but not PRs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason, nice catch!