Skip to content

Conversation

youkaichao
Copy link
Member

add lessons learned from #5484 (comment)

Signed-off-by: youkaichao <[email protected]>
@youkaichao youkaichao linked an issue Nov 11, 2024 that may be closed by this pull request
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 11, 2024
@youkaichao youkaichao merged commit d1c6799 into vllm-project:main Nov 11, 2024
12 of 15 checks passed
@youkaichao youkaichao deleted the debugging_doc branch November 11, 2024 23:21
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NCCL hangs and causes timeout

1 participant