-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Your current environment
v0.8.1
🐛 Describe the bug
Oracle check does no work as expected. Suggested to revert.
The support for v1 should be determined by the pluggable platform, not the current status of in-tree project. This type of forced error seems problematic and redundant with "cuda check" at the last of function. (#15104)
# https://github.com/vllm-project/vllm/blob/main/vllm/engine/arg_utils.py#L1601
if not (current_platform.is_cuda_alike() or current_platform.is_tpu()):
_raise_or_fallback(
feature_name=f"device type={current_platform.device_type}",
recommend_to_remove=False)
return FalseIt will forcely raise for any other platform, even V1 supported. Further, redundant with https://github.com/vllm-project/vllm/blob/main/vllm/engine/arg_utils.py#L1626
Before submitting a new issue...
- Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working