[Fix] Tests breaking with vLLM:Main #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305
The changes in upstream that are breaking tests with vLLM:main branch are twofolds:
model_config.taskwas set toauto, the task could be automatically resolved in vLLM: after the post-init method ofModelConfig, thetaskfield was automatically replaced fromautoto .e.g.generateorembed). With the changes in This PR, the task inmodel_config, cannot be automatically resolved anymore when it isgenerate. This doesn't look like it is intended, but rather a side effect of adding new supported tasks. A cleaner (but longer) way would be to do a PR to vLLM to fix that and reintroduce the automatic resolution ofautotask field.This PR addresses both of the breaking changes:
model_config.supported_tasksrather thanmodel_config.tasknow