[Core] Make V1 work and enable V1 engine test #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiyuan
force-pushed
the
fix_collect_env
branch
3 times, most recently
from
52e56a9 to
b1f58dd
Compare
|
CI is blocked. need this fix be merged first. vllm-project/vllm#15589 |
wangxiyuan
force-pushed
the
fix_collect_env
branch
2 times, most recently
from
2ea048f to
d16b4fa
Compare
wangxiyuan
force-pushed
the
fix_collect_env
branch
5 times, most recently
from
1e0c994 to
98467b3
Compare
This was referenced Mar 28, 2025
Closed
Closed
wangxiyuan
force-pushed
the
fix_collect_env
branch
3 times, most recently
from
e17827b to
cc4f6cd
Compare
Signed-off-by: wangxiyuan <[email protected]>
wangxiyuan
force-pushed
the
fix_collect_env
branch
from
cc4f6cd to
f22c45b
Compare
Yikun
approved these changes
Mar 28, 2025
| e_map) | ||
| # TODO: The native params are: atol=2e-2, rtol=0, maybe related to the nan problem | ||
| torch.testing.assert_close(output, torch_output, atol=4e-2, rtol=1) | ||
| torch.npu.empty_cache() |
There was a problem hiding this comment.
This is a little bit wired, pls move this teardown in followup PR
Yikun
changed the title
ttanzhiqiang
pushed a commit
to ttanzhiqiang/vllm-ascend
that referenced
this pull request
Apr 27, 2025
1. Make sure the version is string before parse in collect_env 2. Add basic V1 engine test Signed-off-by: wangxiyuan <[email protected]>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
1. Make sure the version is string before parse in collect_env 2. Add basic V1 engine test Signed-off-by: wangxiyuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.