[Build] Monkey patch RayWorkerWrapper to make CI work on 0.7.3-dev (#140) #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenguang Li <[email protected]>
wangxiyuan
reviewed
Feb 26, 2025
vllm_ascend/ray_patch.py
Outdated
| @@ -0,0 +1,20 @@ | |||
| import vllm | |||
There was a problem hiding this comment.
move this file to patch folder
Signed-off-by: Chenguang Li <[email protected]>
|
@wangxiyuan, |
|
CI failed |
Signed-off-by: Chenguang Li <[email protected]>
Signed-off-by: Chenguang Li <[email protected]>
Signed-off-by: Chenguang Li <[email protected]>
|
The CI has passed successfully now. The scenario where the user hadn't installed Ray was previously overlooked. |
wangxiyuan
approved these changes
Feb 27, 2025
|
I'm fine with this change on 0.7.3. While for main branch, let's consider a generic way. |
Yikun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR resolves the issue with inference on the Ray backend. For more details, see here.
Does this PR introduce any user-facing change?
no.
How was this patch tested?
Validation was performed based on v0.7.3, and the specific validation script can be found here.