-
Notifications
You must be signed in to change notification settings - Fork 294
Support RHAIIS images for the e2e tests #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhuangnm
wants to merge
40
commits into
main
Choose a base branch
from
imgtest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+165
−16
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f636e2c
Allow using vllm image
dhuangnm afbf811
fix a typo
dhuangnm a55e5c8
fix typo again
dhuangnm ceee681
fix an issue
dhuangnm bcc7a50
fix an issue
dhuangnm 665cd1e
fix cmd string
dhuangnm 4bf0dc1
fix an issue
dhuangnm 59cea15
add debugging
dhuangnm be75c8d
don't delete run folder if using image
dhuangnm 586dcc1
allow using pulled image or deployed runner
dhuangnm c1dde7f
fix a typo
dhuangnm ae9e526
remove extra )
dhuangnm 80352db
run vllm with podman
dhuangnm 8461d03
fix error
dhuangnm 5704e62
fix issues
dhuangnm 098f561
fix path
dhuangnm d564408
improve output
dhuangnm 5da7eee
fix typo
dhuangnm 4cb2251
fix format
dhuangnm d2cb646
fix command
dhuangnm 5cdb543
allow file to execute
dhuangnm 6dc42c4
minor update
dhuangnm 84634e0
copy file
dhuangnm 57c99ac
fix issue
dhuangnm 7cdedbb
run vllm in deployed pod
dhuangnm 3951475
missed ,
dhuangnm 5c401fc
fix command
dhuangnm 870b6ee
remove VLLM_VOLUME_MOUNT_DIR
dhuangnm d23bdf4
fix missing path
dhuangnm 625c9db
clean up
dhuangnm 264fdcb
final update
dhuangnm 318bd3d
clean up
dhuangnm 117ec9d
fix quality failures
dhuangnm 8b41d5f
reorg test code and remove env var
dhuangnm 1b2530e
fix error
dhuangnm 3d889c6
fix another error
dhuangnm 7e77202
fix style
dhuangnm 7662699
clean up and fix format
dhuangnm abb6bab
fix format
dhuangnm de58b02
rename file to be rhaiis specific
dhuangnm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| fp4_nvfp4.yaml | ||
| fp8_dynamic_per_token.yaml | ||
| kv_cache_gptq_tinyllama.yaml | ||
| sparse2of4_fp8_dynamic.yaml | ||
| w4a16_grouped_quant_asym_awq.yaml | ||
| w4a16_actorder_weight.yaml | ||
| int8_channel_weight_static_per_tensor_act.yaml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| #!/bin/bash | ||
|
|
||
| usage() { | ||
| echo "Usage: $0 -c <config> -t <test> -s <save_dir>" | ||
| exit 1 | ||
| } | ||
|
|
||
| while getopts "c:t:s:" OPT; do | ||
| case ${OPT} in | ||
| c ) | ||
| CONFIG="$OPTARG" | ||
| ;; | ||
| t ) | ||
| TEST="$OPTARG" | ||
| ;; | ||
| s ) | ||
| SAVE_DIR="$OPTARG" | ||
| ;; | ||
| \? ) | ||
| exit 1 | ||
| ;; | ||
| esac | ||
| done | ||
|
|
||
| if [[ -z "$CONFIG" || -z "$TEST" || -z "$SAVE_DIR" ]]; then | ||
| echo "Error: -c, -t, and -s are required." | ||
| usage | ||
| fi | ||
|
|
||
| script_path=$(dirname "${BASH_SOURCE[0]}") | ||
| if [ -d "$CONFIG" ]; then | ||
| echo "Config is provided as a folder: $CONFIG" | ||
| CONFIGS=`ls "$CONFIG"` | ||
| elif [ -f "$CONFIG" ]; then | ||
| echo "Config is provided as a file: $CONFIG" | ||
| CONFIGS=`cat "$CONFIG"` | ||
| fi | ||
|
|
||
| SUCCESS=0 | ||
|
|
||
| # Parse list of configs and add save_dir | ||
| rm -rf $SAVE_DIR/configs | ||
| mkdir -p $SAVE_DIR/configs | ||
| for MODEL_CONFIG in $(echo -e "$CONFIGS" | sed "s|^|${script_path}/configs/|") | ||
| do | ||
| FILE_NAME=$(basename $MODEL_CONFIG) | ||
| CONFIG_FILE=$SAVE_DIR/configs/$FILE_NAME | ||
|
|
||
| save_dir=$(cat $MODEL_CONFIG | grep 'save_dir:' | cut -d' ' -f2) | ||
| model=$(cat $MODEL_CONFIG | grep 'model:' | cut -d'/' -f2) | ||
| scheme=$(cat $MODEL_CONFIG | grep 'scheme:' | cut -d' ' -f2) | ||
|
|
||
| # add or overwrite save_dir for each model | ||
| if [[ -z "$save_dir" ]]; then | ||
| { cat $MODEL_CONFIG; echo -e "\nsave_dir: $SAVE_DIR/$model-$scheme"; } > $CONFIG_FILE | ||
| else | ||
| { cat $MODEL_CONFIG | grep -v 'save_dir'; echo "save_dir: $SAVE_DIR/$save_dir"; } > $CONFIG_FILE | ||
| fi | ||
|
|
||
| echo "=== RUNNING MODEL: $CONFIG_FILE ===" | ||
| cat $CONFIG_FILE | ||
|
|
||
| LOCAL_SUCCESS=0 | ||
| export TEST_DATA_FILE="$CONFIG_FILE" | ||
| pytest \ | ||
| --capture=tee-sys \ | ||
| "$TEST" || LOCAL_SUCCESS=$? | ||
|
|
||
| if [[ $LOCAL_SUCCESS == 0 ]]; then | ||
| echo "=== PASSED MODEL: $CONFIG_FILE ===" | ||
| else | ||
| echo "=== FAILED MODEL: $CONFIG_FILE ===" | ||
| fi | ||
|
|
||
| SUCCESS=$((SUCCESS + LOCAL_SUCCESS)) | ||
|
|
||
| done | ||
|
|
||
| exit "$SUCCESS" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.