-
Notifications
You must be signed in to change notification settings - Fork 306
[model_free_ptq] Add pathway for day-zero weight quantization support
#1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
f4423c1 to
294a78a
Compare
weights_ptq pathway for day-zero weight quantization supportweights_ptq pathway for day-zero weight quantization support
weights_ptq pathway for day-zero weight quantization supportptq_weights pathway for day-zero weight quantization support
ptq_weights pathway for day-zero weight quantization supportptq_weights pathway for day-zero weight quantization support
Signed-off-by: Kyle Sayers <[email protected]>
1c56a75 to
6fe9db9
Compare
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
ptq_weights pathway for day-zero weight quantization supportmodel_free_ptq] Add pathway for day-zero weight quantization support
Signed-off-by: Kyle Sayers <[email protected]>
dsikka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping this as a separate entrypoint makes sense given the point is speed of execution / not wanting it getting bogged down from other flows in llmcomp but it seems like the lifecycle / steps we're applying are very similar to the datafree pipeline?
|
@dsikka Yes |
brian-dellabetta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! One nit, and probably want to add an example or README to explain when one would want to use this over oneshot, but can also tackle that in a follow up as a good first issue.
shanjiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
Purpose
Usage
Testing
test_model_free_ptq_matches_oneshotwhich tests that saved tensors and configs exactly match betweenmodel_free_ptqandoneshotentrypoints for the same arguments. This test takes about 10 seconds to run.Future Extensions