Skip to content

Conversation

ExtReMLapin
Copy link

No description provided.

@ExtReMLapin ExtReMLapin marked this pull request as ready for review July 11, 2025 07:45
@ExtReMLapin
Copy link
Author

Tested on a RTX 5090 with fp8 quantization AND tensor split at 2, working 👍🏻

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me since we build for 8.0+PTX;

can you please just sign off on the commits so the DCO passes

@ExtReMLapin
Copy link
Author

ExtReMLapin commented Jul 17, 2025

Sorry about the DCO thing, most of my PR are rushed
should be good now

@ExtReMLapin
Copy link
Author

@LucasWilkinson anything else missing ?

@LucasWilkinson LucasWilkinson merged commit 2c87db5 into vllm-project:main Jul 28, 2025
1 check passed
@LucasWilkinson
Copy link
Collaborator

Looks good, thanks for the contribution!

jayhshah pushed a commit that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants