Eliminate c10::optional usage in vllm_flash_attn #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseroad
force-pushed
the
fb-sync-lufang
branch
from
8058e1c to
8927644
Compare
|
Introduced again in #33. Clean up again. |
baa5235524cdb0c60ff8a448c802ff575122b986 Lu Fang <[email protected]> Eliminate c10::optional usage in vllm_flash_attn Signed-off-by: Lu Fang <[email protected]>
houseroad
force-pushed
the
fb-sync-lufang
branch
from
8927644 to
5d95266
Compare
WoosukKwon
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baa5235524cdb0c60ff8a448c802ff575122b986 Lu Fang [email protected] Eliminate c10::optional usage in vllm_flash_attn
Otherwise, it may fail the build.