fix: ensure module in graph before transforming #12774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… error during the load function. The position of the watcher changed so that the file review would start before the load function is executed, and in the event of an error, the primary renderer will not crash and the file will be able to be watched.
|
|
patak-dev
added
the
p3-minor-bug
9 tasks
bluwy
approved these changes
Apr 7, 2023
9 tasks
patak-dev
pushed a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rebase #11605, sending this as a new PR as the branch seems deleted. This change makes sense to me to align with the way we are constructing the module graph during import analysis.
What is the purpose of this pull request?