fix: enable retainLines to get correct line numbers for jsxDev #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I just spent some time trying to figure out why source references were off by 3 lines. This fixes the issue |
sapphi-red
approved these changes
Oct 30, 2023
patak-dev
approved these changes
Oct 30, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #235
I did some benchmarking and using retainLines has no impact on transformation time, but using the babel JSX transform plugin slowdown by around 40% the pipeline. I think this fix is a good trade off and avoid to break other plugins that now rely on the JSX transformation to be done at the esbuild step.