-
Notifications
You must be signed in to change notification settings - Fork 35
Migrate to Codecov, update Python 3.13, and refine tox configuration #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request adds Python 3.13 and Django 5.2 support, migrates coverage reporting from Coveralls to Codecov, updates project configuration metadata and coverage settings, and refreshes documentation badges and frontend scripts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage ? 93.82%
=======================================
Files ? 19
Lines ? 696
Branches ? 49
=======================================
Hits ? 653
Misses ? 33
Partials ? 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Use a semantically versioned Codecov action (e.g.
codecov/codecov-action@v5) instead of a pinned commit SHA for easier maintenance and upgrades. - Confirm that the frontend coverage output path (
./frontend/coverage/lcov.info) aligns with wherepnpm run coverageactually writes the lcov file in CI. - Since Django 5.0 support was removed in tox, consider cleaning up any leftover 5.0 references in classifiers or comments to avoid confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Use a semantically versioned Codecov action (e.g. `codecov/codecov-action@v5`) instead of a pinned commit SHA for easier maintenance and upgrades.
- Confirm that the frontend coverage output path (`./frontend/coverage/lcov.info`) aligns with where `pnpm run coverage` actually writes the lcov file in CI.
- Since Django 5.0 support was removed in tox, consider cleaning up any leftover 5.0 references in classifiers or comments to avoid confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fjsj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary by Sourcery
Migrate coverage reporting to Codecov, add Python 3.13 support across CI, tox, and project metadata, and refine testing and workflow configurations
New Features:
Enhancements: