Recognise new cabal config location

[coot]

No description provided.

[codecov]

Codecov Report

Merging #12463 (33d23e8) into master (c9fbd25) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12463      +/-   ##
==========================================
+ Coverage   82.06%   82.09%   +0.02%     
==========================================
  Files         160      160              
  Lines      193588   193625      +37     
  Branches    43472    43475       +3     
==========================================
+ Hits       158877   158951      +74     
+ Misses      21853    21836      -17     
+ Partials    12858    12838      -20     

Flag	Coverage Δ
huge-clang-none	82.74% <ø> (+0.01%)	⬆️
linux	82.74% <ø> (+0.01%)	⬆️
mingw-x64-HUGE	76.61% <ø> (+0.04%)	⬆️
mingw-x86-HUGE	77.07% <ø> (+0.03%)	⬆️
windows	78.20% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

[brammool]

When $XDG_CONFIG_HOME is set then using $XDG_CONFIG_HOME/.cabal/config makes sense. But why drop $HOME/.config/cabal/config then? I see no problem in recognizing both as cabalconfig. Please add a test entry for this. You may need something more than an entry in the table, setting $XDG_CONFIG_HOME before the filetype.vim file is read. Deleting g:did_load_filetypes should help with that. While at it, we can expect other entries using $XDG_CONFIG_HOME. It's already in use for Git files. Would be good to test multiple filetypes there. If you don't want to do this now, please add a TODO comment somewhere.

…

-- From "know your smileys": :-D Big smile /// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[coot]

I tried to set XDG_CONFIG_HOME in Test_filetype_detection with:

  if !empty(windowsversion())
    let $XDG_CONFIG_HOME=expand("$HOME/.config")
  endif

and vim complains with:

Found errors in Test_filetype_detection():
Caught exception in Test_filetype_detection(): Vim(call):E1126: Cannot use :let in Vim9 script @ command line..script /home/coot/src/vim/src/testdir/runtest.vim[569]..function Ru
nTheTest[52]..Test_filetype_detection, line 2

[coot]

Oh, I see var should be used, but it doesn't support setting environment variables. Maybe there's a function for that now...

[coot]

@brammool I added a test which caught a mistake 🎉.

[brammool]

I tried to set `XDG_CONFIG_HOME` in `Test_filetype_detection` with: ``` if !empty(windowsversion()) let $XDG_CONFIG_HOME=expand("$HOME/.config") endif ``` and `vim` complains with: ``` Found errors in Test_filetype_detection(): Caught exception in Test_filetype_detection(): Vim(call):E1126: Cannot use :let in Vim9 script @ command line..script /home/coot/src/vim/src/testdir/runtest.vim[569]..function RunTheTest[52]..Test_filetype_detection, line 2 ```

Right, you can just drop the "let": $XDG_CONFIG_HOME = expand("$HOME/.config") For checking if an environment variable exists using exists('$NAME') is simpler and more explicit than has_key() and environ(). I'll make it like that. It's better not the create test files under $HOME, in case the test aborts files may be left behind unnoticed. That requires a few more changes, I'll do that. Please check with what I ended up with.

…

-- An error has occurred. Hit any user to continue. /// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///