Reduce time for creating Ruby's config.h #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use git clone to get the Ruby source code. However it extracts all the source code. Actually we need only a few files to create config.h. Download the source code in a zip package, then extract only necessary files by using 7-Zip. Note that we need to use `^^` to escape `!` because we enable delayed expansion.
Also add some error checking.
Member
|
I think looks good, although I scratched my head around the 7z syntax. I suppose this worked in your local fork? |
Member
Author
|
Yes, this is tested: We only need the following files for creating config.h: |
Member
|
okay good. How about adding a part of your commit message as comment "Note that we need to use |
Member
Author
|
Done. |
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to extract whole Ruby source to create config.h.
Extract only required files.
Also add some error checking and reduce some log messages.