Skip to content

Conversation

@mityu
Copy link
Contributor

@mityu mityu commented May 8, 2025

On MacVim (must also on gVim, I can't check now though), the cursor disappears after using fall.vim. This PR fixes it.

Checked Environment

  • macOS Sequoia
  • MacVim 9.1.1251

Reproduce Steps

  • Prepare this vimrc.vim
set nocompatible

" Please modify these runtimepath value
set runtimepath^=~/.cache/vim/pack/minpac/opt/denops.vim/
set runtimepath^=~/.cache/vim/pack/minpac/opt/fall.vim/

let g:fall_custom_path = '/tmp/notfound.vim'
  • Launch gVim(MacVim) with gvim -u vimrc.vim
    • Maybe you can use /Applications/MacVim.app/Contents/bin/mvim -u vimrc.vim
  • Check the cursor exists
  • Run fall.vim, e.g. :Fall file, and then quit it
  • The cursor is still hidden

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (934910e) to head (6f34e61).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files          24       24           
  Lines        1671     1671           
  Branches      165      165           
=======================================
  Hits         1352     1352           
  Misses        316      316           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@lambdalisue lambdalisue merged commit c4f79d4 into vim-fall:main May 9, 2025
6 checks passed
@mityu mityu deleted the fix-guicursor branch May 9, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants