Fix highlight may not be restored

[mityu]

When MsgArea highlight is defined with :highlight-link, MsgArea highlight is not restored properly.

Reproduce steps

• Prepare a terminal with true color support.
• Prepare this vimrc.vim.

set nocompatible
set runtimepath^=~/.cache/vim/pack/minpac/opt/denops.vim/
set runtimepath^=~/.cache/vim/pack/minpac/opt/vim-fall/
set termguicolors
colorscheme habamax
highlight! link MsgArea ErrorMsg

• Launch Vim (not Neovim) with vim -u /path/to/vimrc.vim
• Check MsgArea highlight.
• Run command :Fall line.
• Type <ESC> to exit fall.vim
• Check MsgArea highlight. It's different from before.

Environment

• macOS 14
• wezterm 20240203-110809-5046fc22
• Vim 9.1.0658

Summary by CodeRabbit

• New Features

  • Enhanced highlight settings management for improved control over highlighting behavior.

• Bug Fixes

  • Improved functionality of highlight application to ensure consistent visual representation.

[coderabbitai]

Walkthrough

The recent changes enhance the way highlight settings are applied in the hlset function within msgarea.vim. By modifying the invocation to include additional parameters, the changes improve control over highlighting behavior. This update maintains the function's overall logic while allowing for more flexibility in managing visual attributes.

Changes

Files	Change Summary
autoload/fall/internal/msgarea.vim	Modified hlset function call to include a new list with force key and first element of s:hl_msgarea, enhancing highlight control.

Poem

🐰 In the code where highlights bloom,
A tweak was made to brighten the room.
With forced colors shining so bright,
The rabbit hops with pure delight!
Each message now with flair anew,
A joyful dance in every hue! 🌈

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9dba8a3 and 654e3fe.

Files selected for processing (1)

• autoload/fall/internal/msgarea.vim (1 hunks)

Additional comments not posted (1)

autoload/fall/internal/msgarea.vim (1)

52-52: Ensure correctness of the hlset modification.

The change to include a force key in the hlset call is intended to ensure that the highlight settings are applied consistently. This modification looks correct, but please verify that this change does not introduce any unintended side effects.