-
-
Notifications
You must be signed in to change notification settings - Fork 33
☕ (ci) bump denoland/setup-deno from v1 to v2 #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe workflow configuration was updated to rename the Deno version matrix key from Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 27 27
Lines 1462 1462
Branches 189 190 +1
=======================================
Hits 1418 1418
Misses 40 40
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
.github/workflows/test.yml (1)
85-88
: Same pin-version & input-name observations as in thecheck
jobMirror whatever decision you take for the
check
job (v2.x.y
pinning, input validation).
🧹 Nitpick comments (2)
.github/workflows/test.yml (2)
43-46
: Action bumped tosetup-deno@v2
– pin minor/patch to avoid surprise breaks
v2
will float to every new minor/patch release. To keep CI reproducible you may prefer an explicit tag such asv2.1.0
(or whatever is current).- - uses: denoland/setup-deno@v2 + - uses: denoland/[email protected]Also verify the input name remains
deno-version
in v2 (docs say yes, but safer to confirm).
69-72
: Matrix expansion LGTM – consider limiting to a single “latest 1.x” if runtime minutes explodeTesting explicit
1.45.0
,1.x
, and2.x
gives great coverage, but triples job count.
If CI time becomes an issue, pick one fixed 1.x or rely on1.x
rolling forward.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml
(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
.github/workflows/test.yml (1)
Learnt from: Milly
PR: vim-denops/denops.vim#418
File: tests/denops/runtime/functions/plugin/check_type_test.ts:6-6
Timestamp: 2024-09-14T17:09:30.174Z
Learning: In this project, import paths prefixed with `/denops-testdata/` are defined in `deno.jsonc` via an import map, and these import paths are valid.
🔇 Additional comments (1)
.github/workflows/test.yml (1)
35-38
: No lingering${{ matrix.version }}
references foundConfirmed with a repository-wide search that all references have been updated to
matrix.deno_version
.
Summary by CodeRabbit