-
-
Notifications
You must be signed in to change notification settings - Fork 33
Support import_map.json[c]
in denops plugin directory
#446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Denops
participant Plugin
participant PluginModule
Denops->>Plugin: new Plugin(denops, name, script)
Plugin->>Plugin: load()
Plugin->>PluginModule: dynamic import (with import map support)
PluginModule-->>Plugin: exports main()
Plugin->>PluginModule: main(denops)
PluginModule-->>Plugin: AsyncDisposable resource
Plugin-->>Denops: emit lifecycle events
Denops->>Plugin: call(fn, ...args)
Plugin->>PluginModule: dispatcher[fn](...args)
PluginModule-->>Plugin: result
Denops->>Plugin: unload()
Plugin->>PluginModule: dispose AsyncDisposable
Plugin-->>Denops: emit unload events
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ac096b5
to
2b38087
Compare
9e5e49e
to
fb3732e
Compare
import_map.json[c]
in denops plugin directory
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 95.83% 96.99% +1.16%
==========================================
Files 25 27 +2
Lines 1415 1462 +47
Branches 181 189 +8
==========================================
+ Hits 1356 1418 +62
+ Misses 56 40 -16
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fb3732e
to
fd439c6
Compare
Now if the plugin has `import_map.json` or `import_map.jsonc` in the same directory with `main.ts`, it will be loaded automatically and used to resolve imports.
6d36446
to
955a3fe
Compare
Summary
deno.json
anddeno.jsonc
files in denops plugin directories (withworkspace
feature of Deno)import_map.json
andimport_map.jsonc
files in denops plugin directoriesTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit