🐛 Fix row/col on popup.open

[lambdalisue]

Close #274

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the col and row properties for Neovim window settings to account for 0-based indexing, ensuring correct positioning.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes made in the pull request focus on the toNvimWinSetConfig function within the popup/nvim.ts file. The modifications adjust the assignment of the col and row properties in the configuration object to account for Neovim's 0-based indexing. Specifically, the new implementation subtracts 1 from these values when they are defined, ensuring that the coordinates passed to Neovim are accurate according to its indexing system.

Changes

File	Change Summary
popup/nvim.ts	Adjusted col and row properties in toNvimWinSetConfig to subtract 1 for Neovim's 0-based indexing.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure popup window positions are consistent between Vim and Neovim (#274)	✅

🐇 In the land of code where the popups play,
A fix was made to brighten the day.
With rows and columns now aligned just right,
Neovim and Vim can share the same sight!
Hopping along, no more floating in vain,
A joyful leap, no more coding pain! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (ec2d3ab) to head (a2f44f9).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
popup/nvim.ts	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   85.97%   85.91%   -0.06%     
==========================================
  Files          63       63              
  Lines        3415     3416       +1     
  Branches      299      301       +2     
==========================================
- Hits         2936     2935       -1     
- Misses        477      479       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.