Bump version to Vim 9.1.0448 and Nvim 0.10.0 #247
Conversation
In Neovim 0.10.0, `(default ...)` in `options.txt` is indented with spaces instead of tabs when it contains newlines.
Changes in 1470dcd are invalid, that version has been revised in the official version of v7. See: vim-denops/denops.vim#344
WalkthroughThis update introduces several enhancements across multiple scripts, focusing on version upgrades for VIM and NVIM, improvements in error handling, and modifications to parsing logic. Functionality is expanded with new features, streamlined options, and refined documentation to boost usability. The changes aim to enhance performance, clarity, and user experience while maintaining compatibility with existing systems. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant API
User->>App: Request to update settings
App->>API: Send new options
API-->>App: Acknowledge changes
App-->>User: Confirm update success
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (13)
function/vim/_generated.ts (11)
The function
test_garbagecollect_nowis still present in the codebase.Please ensure that all references to the
test_garbagecollect_nowfunction are removed or updated to prevent potential runtime errors.
function/_generated.ts: The functiontest_garbagecollect_nowis still defined and referenced.Analysis chain
Line range hint
1-1:
Verify the removal oftest_garbagecollect_now.Ensure that all references to the
test_garbagecollect_nowfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `test_garbagecollect_now` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'test_garbagecollect_now'Length of output: 86
Script:
#!/bin/bash # Description: Verify all references to the `test_garbagecollect_now` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg -A 5 $'test_garbagecollect_now'Length of output: 959
Ensure removal of
luaevalfunction and references.The
luaevalfunction and its references are still present in thefunction/_generated.tsfile. Please remove the following occurrences to prevent potential runtime errors:
function/_generated.ts: * Seelua-luaevalfor more details.function/_generated.ts: * GetExpr()->luaeval()function/_generated.ts:export function luaeval(denops: Denops, ...args: unknown[]): Promise<unknown> {function/_generated.ts: return denops.call("luaeval", ...args);Analysis chain
Line range hint
1-1:
Verify the removal ofluaeval.Ensure that all references to the
luaevalfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `luaeval` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'luaeval'Length of output: 70
Script:
#!/bin/bash # Description: Verify all references to the `luaeval` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type ts -A 5 luaevalLength of output: 1149
Verify the removal of
maplist.The
maplistfunction is still referenced multiple times in thefunction/_generated.tsfile. Ensure that all references to themaplistfunction have been removed or updated to prevent runtime errors and maintain accurate documentation.
function/_generated.ts: Multiple references tomaplistfound.Analysis chain
Line range hint
1-1:
Verify the removal ofmaplist.Ensure that all references to the
maplistfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `maplist` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'maplist'Length of output: 70
Script:
#!/bin/bash # Description: Verify all references to the `maplist` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --glob '*.ts' -A 5 $'maplist'Length of output: 3394
The
assert_equalfunction is still present in the codebase.The search results indicate that the
assert_equalfunction and its references are still present infunction/_generated.ts. Please ensure that all instances of this function are fully removed if the intention was to eliminate it from the codebase.
function/_generated.tsAnalysis chain
Line range hint
1-1:
Verify the removal ofassert_equal.Ensure that all references to the
assert_equalfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `assert_equal` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'assert_equal'Length of output: 75
Script:
#!/bin/bash # Description: Verify all references to the `assert_equal` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type ts -A 5 $'assert_equal'Length of output: 3252
Issues Found:
The
slicefunction is still being referenced in multiple files across the codebase. Removing the function fromfunction/_generated.tswithout addressing these references will likely result in runtime errors.
helper/expr_string.tsfunction/_generated.tsbuffer/fileformat.tsargument/opts.tsargument/flags.tsPlease ensure that all references to the
slicefunction are either removed or appropriately updated.Analysis chain
Line range hint
1-1:
Verify the removal ofslice.Ensure that all references to the
slicefunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `slice` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'slice'Length of output: 68
Script:
#!/bin/bash # Description: Verify all references to the `slice` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type ts -A 5 $'slice'Length of output: 3232
Ensure all references to the
statefunction are removed or updated.The
statefunction is still referenced in multiple files. To prevent runtime errors, please update or remove the following references:
function/_generated.tsfunction/various.tsoption/vim/_generated.tsoption/_generated.tsoption/nvim/_generated.tsfunction/nvim/_generated.tsfunction/cursor.tshelper/echo.tsAnalysis chain
Line range hint
1-1:
Verify the removal ofstate.Ensure that all references to the
statefunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `state` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'state'Length of output: 68
Script:
#!/bin/bash # Description: Verify all references to the `state` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --glob '*.ts' -A 5 $'state'Length of output: 12196
The
assert_falsefunction has not been fully removed.The
assert_falsefunction is still defined and referenced in thefunction/_generated.tsfile. Please ensure all instances of this function are removed or updated to prevent runtime errors.
function/_generated.ts:
- Line with
call assert_false(1, 'command should have failed')- Line with
GetResult()->assert_false()- Function definition and export of
assert_falseAnalysis chain
Line range hint
1-1:
Verify the removal ofassert_false.Ensure that all references to the
assert_falsefunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `assert_false` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'assert_false'Length of output: 75
Script:
#!/bin/bash # Description: Verify all references to the `assert_false` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg 'assert_false' --glob '*.ts' -A 5Length of output: 1166
The
swapfilelistfunction is still present in the codebase.The function
swapfilelistwas expected to be removed, but it is still found in the following locations:
function/_generated.ts: Multiple referencesPlease review and ensure that all references to the
swapfilelistfunction are removed if it is intended to be deleted.Analysis chain
Line range hint
1-1:
Verify the removal ofswapfilelist.Ensure that all references to the
swapfilelistfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `swapfilelist` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'swapfilelist'Length of output: 75
Script:
#!/bin/bash # Description: Verify all references to the `swapfilelist` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type ts -A 5 $'swapfilelist'Length of output: 756
The
matchstrlistfunction is still present in the codebase.The
matchstrlistfunction has not been fully removed. It is still referenced and defined in thefunction/_generated.tsfile at the following locations:
- Lines showing usage examples and documentation.
- Lines defining and exporting the function.
Please ensure that all references to the
matchstrlistfunction are removed or updated to prevent any inconsistencies.
Analysis chain
Line range hint
1-1:
Verify the removal ofmatchstrlist.Ensure that all references to the
matchstrlistfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `matchstrlist` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'matchstrlist'Length of output: 75
Script:
#!/bin/bash # Description: Verify all references to the `matchstrlist` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type ts -A 5 $'matchstrlist'Length of output: 1912
The
utf16idxfunction has not been removed.The search results indicate that the
utf16idxfunction is still present in thefunction/_generated.tsfile, including its definition and references in the documentation.
function/_generated.ts: Multiple occurrences ofutf16idxare found, including its function definition and documentation.Please ensure that all references to the
utf16idxfunction are removed or updated to prevent any potential runtime errors.Analysis chain
Line range hint
1-1:
Verify the removal ofutf16idx.Ensure that all references to the
utf16idxfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `utf16idx` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'utf16idx'Length of output: 71
Script:
#!/bin/bash # Description: Verify all references to the `utf16idx` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg -A 5 $'utf16idx'Length of output: 2132
Script:
#!/bin/bash # Description: Verify all references to the `utf16idx` function have been removed or updated. # Test: Search for the function usage across the entire codebase. Expect: No occurrences of the old function. rg -A 5 $'utf16idx'Length of output: 2132
The
mapnewfunction has not been removed.The
mapnewfunction is still defined and referenced in the codebase, specifically infunction/_generated.ts. Please review the following occurrences:
function/_generated.ts:
- Lines mentioning
mapnewin comments and function definitions.Please ensure that the removal of the
mapnewfunction is correctly implemented if it is intended to be removed.Analysis chain
Line range hint
1-1:
Verify the removal ofmapnew.Ensure that all references to the
mapnewfunction have been removed or updated to prevent runtime errors.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to the `mapnew` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type typescript -A 5 $'mapnew'Length of output: 69
Script:
#!/bin/bash # Description: Verify all references to the `mapnew` function have been removed or updated. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type ts -A 5 $'mapnew'Length of output: 1394
option/vim/_generated.ts (2)
Issues found: Incomplete removal of
smoothscrollThe removal of
smoothscrollis incomplete, and there are still multiple references to it in the codebase that need to be addressed:
option/_generated.ts: Lines 12803, 12805, 12809, 12812, 12815, 12819, 12822, 12825, 12829, 12832, and 12836.function/nvim/_generated.ts: Line 3400.Please ensure these references are removed or updated to prevent any potential issues.
Analysis chain
Line range hint
1-1:
Verify the impact of removingsmoothscroll.The removal of
smoothscrollmight affect functionalities related to smooth scrolling. Ensure there are no dangling references or broken functionalities.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the removal of `smoothscroll`. # Test: Search for references to `smoothscroll`. Expect: No references found. rg --type typescript 'smoothscroll'Length of output: 70
Script:
#!/bin/bash # Description: Verify the removal of `smoothscroll`. # Test: Search for references to `smoothscroll`. Expect: No references found. rg --type ts 'smoothscroll'Length of output: 1017
Script:
#!/bin/bash # Description: List lines containing `smoothscroll` in the relevant files for detailed inspection. # List lines in `option/_generated.ts` rg --type ts 'smoothscroll' option/_generated.ts -n # List lines in `function/nvim/_generated.ts` rg --type ts 'smoothscroll' function/nvim/_generated.ts -nLength of output: 912
Issues found due to the removal of
winfixbuf.The removal of
winfixbuffromoption/vim/_generated.tsleaves several active references in the codebase, which could lead to broken functionalities related to window buffer pairing behavior. Please ensure that all references towinfixbufare appropriately handled before proceeding with its removal.
- References found in
option/_generated.ts:
export const winfixbuf: LocalOption<boolean> = { ... }- Functions using
winfixbuffor getting, setting, and removing options.Analysis chain
Line range hint
1-1:
Verify the impact of removingwinfixbuf.The removal of
winfixbufmight affect functionalities related to window buffer pairing behavior. Ensure there are no dangling references or broken functionalities.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the removal of `winfixbuf`. # Test: Search for references to `winfixbuf`. Expect: No references found. rg --type typescript 'winfixbuf'Length of output: 67
Script:
#!/bin/bash # Description: Verify the removal of `winfixbuf`. # Test: Search for references to `winfixbuf`. Expect: No references found. rg --type-add 'ts:*.ts' 'winfixbuf'Length of output: 1073
Script:
#!/bin/bash # Description: Verify the context of `winfixbuf` references. # Test: Check the context of `winfixbuf` references to see if they are commented out or still active. rg --type-add 'ts:*.ts' 'winfixbuf' -A 3 -B 3Length of output: 3236
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (15)
- .scripts/gen-function/gen-function.ts (1 hunks)
- .scripts/gen-function/parse.ts (1 hunks)
- .scripts/gen-option/gen-option.ts (3 hunks)
- .scripts/gen-option/parse.ts (3 hunks)
- .scripts/markdown.ts (1 hunks)
- .scripts/utils.ts (1 hunks)
- function/_generated.ts (14 hunks)
- function/common.ts (3 hunks)
- function/nvim/_generated.ts (115 hunks)
- function/nvim/nvim_open_win.ts (5 hunks)
- function/nvim/nvim_win_set_config.ts (1 hunks)
- function/vim/_generated.ts (9 hunks)
- option/_generated.ts (3 hunks)
- option/nvim/_generated.ts (13 hunks)
- option/vim/_generated.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- .scripts/gen-function/gen-function.ts
- function/common.ts
Additional comments not posted (61)
function/nvim/nvim_win_set_config.ts (2)
6-7: Documentation update improves clarity.The added note about not being able to move the last window in a tabpage is clear and helpful.
9-10: Generalized documentation improves understanding.Changing "floating window" to "a window" broadens the context and improves clarity.
.scripts/utils.ts (1)
9-9: Improved error handling.Checking the response status for 400 or higher ensures better error handling for unsuccessful HTTP requests.
.scripts/gen-option/gen-option.ts (2)
8-9: Version updates.Updating VIM to 9.1.0448 and NVIM to 0.10.0 ensures compatibility with the latest features and fixes.
39-39: Improved parsing logic.Concatenating help documents into a single string before parsing simplifies the logic and may improve performance.
.scripts/markdown.ts (2)
15-16: Verify the necessity and future use of the_ftcapturing group.The regex pattern has been updated to include a named capturing group
(?<ft>\w*), but the captured group_ftis currently not used in the callback function. Ensure that this change is necessary and consider utilizing or removing the_ftgroup to avoid confusion.
16-18: Verify the necessity and future use of the_ftparameter.The
_ftparameter is introduced in the callback function but is currently unused. Ensure that this change is necessary and consider utilizing or removing the_ftparameter to avoid confusion..scripts/gen-option/parse.ts (4)
32-32: LGTM! Improved error reporting withblockproperty.The addition of the
blockproperty to theerrorsarray enhances the error reporting mechanism by providing better context for debugging.
48-61: LGTM! Enhanced error messages withblockcontext.The updated error handling logic provides more informative error messages by including the relevant block of text associated with each parsing error, improving the debugging experience.
113-114: LGTM! Improved regex pattern for multiline default values.The refined regex pattern for default values improves the robustness of the parsing logic by correctly handling multiline default values that are indented with either tabs or spaces.
Line range hint
113-119:
LGTM! Enhanced parsing logic and error reporting.The updated
parseBlockfunction includes the refined regex pattern for default values and the improved error handling logic, collectively enhancing the functionality of theparsefunction..scripts/gen-function/parse.ts (2)
61-61: LGTM! Improved error message format.The adjusted error message format enhances clarity in the output by clearly distinguishing the function name, improving the debugging experience.
63-65: LGTM! Enhanced error context with block markers.The new console error statements provide better context by logging the content of the block being parsed, aiding in debugging by allowing developers to see the exact content that caused the failure.
function/nvim/nvim_open_win.ts (12)
4-25: Documentation improvements are clear and accurate.The enhancements to the documentation provide clear instructions on the parameters and capabilities of the
nvim_open_winfunction.
38-53: Example section improvements are clear and effective.The enhanced examples provide clear and structured demonstrations of how to use the
nvim_open_winfunction with various parameters.
Line range hint
54-175:
Attributes section improvements are comprehensive and useful.The new parameters
footer,fixed, andhideadd flexibility and usability to thenvim_open_winfunction.
Line range hint
176-183:
Function declaration updates are accurate.The function declaration has been correctly updated to include the new parameters.
Line range hint
184-191:
Interface updates are accurate.The interface
NvimOpenWinConfighas been correctly updated to include the new parameters.
Line range hint
192-200:
relativeparameter description updates are accurate.The description of the
relativeparameter has been correctly updated.
Line range hint
201-203:
winparameter description updates are accurate.The description of the
winparameter has been correctly updated.
Line range hint
204-208:
anchorparameter description updates are accurate.The description of the
anchorparameter has been correctly updated.
Line range hint
209-213:
widthandheightparameter description updates are accurate.The descriptions of the
widthandheightparameters have been correctly updated.
Line range hint
214-221:
bufposparameter description updates are accurate.The description of the
bufposparameter has been correctly updated.
Line range hint
222-226:
focusableparameter description updates are accurate.The description of the
focusableparameter has been correctly updated.
Line range hint
227-230:
externalparameter description updates are accurate.The description of the
externalparameter has been correctly updated.option/nvim/_generated.ts (7)
21-21:channeloption documentation updates are accurate.The documentation for the
channeloption has been correctly updated.
Line range hint
102-116:
inccommandoption documentation updates are accurate.The documentation for the
inccommandoption has been correctly updated.
155-156:mousescrolloption documentation updates are accurate.The documentation for the
mousescrolloption has been correctly updated.
217-217:pumblendoption documentation updates are accurate.The documentation for the
pumblendoption has been correctly updated.
248-248:scrollbackoption documentation updates are accurate.The documentation for the
scrollbackoption has been correctly updated.
378-378:shadaoption documentation updates are accurate.The documentation for the
shadaoption has been correctly updated.
604-633: Addition oftermsyncoption is well-implemented.The new
termsyncoption is implemented correctly and consistently with other options.function/vim/_generated.ts (9)
Line range hint
1-1:
Verify the removal offoreach.Ensure that all references to the
foreachfunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofgetregion.Ensure that all references to the
getregionfunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofassert_fails.Ensure that all references to the
assert_failsfunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofmatchbufline.Ensure that all references to the
matchbuflinefunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofassert_beeps.Ensure that all references to the
assert_beepsfunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofassert_equalfile.Ensure that all references to the
assert_equalfilefunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofassert_exception.Ensure that all references to the
assert_exceptionfunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofstrutf16len.Ensure that all references to the
strutf16lenfunction have been removed or updated to prevent runtime errors.
Line range hint
1-1:
Verify the removal ofassert_inrange.Ensure that all references to the
assert_inrangefunction have been removed or updated to prevent runtime errors.function/nvim/_generated.ts (3)
1573-1583: Ensure proper error handling fornvim__complete_setfunction.The function
nvim__complete_setsets completion information. Ensure that proper error handling is implemented for invalidindexoroptsvalues.
1750-1756: Ensure proper validation fornvim__redrawfunction parameters.The function
nvim__redrawredraws various components. Ensure that proper validation is implemented for theoptsparameter to handle invalid values.
3621-3631: Ensure proper validation fornvim__win_add_nsfunction parameters.The function
nvim__win_add_nsscopes a namespace to a window. Ensure that proper validation is implemented for thewindowandns_idparameters to handle invalid values.function/_generated.ts (14)
10066-10100: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
strutf16lenare correctly implemented.Verification successful
LGTM! But verify the function usage in the codebase.
The code changes are approved.
However, ensure that all function calls to
strutf16lenare correctly implemented.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `strutf16len` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type typescript -A 5 $'strutf16len'Length of output: 74
Script:
#!/bin/bash # Description: Verify all function calls to `strutf16len` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type ts -A 5 $'strutf16len'Length of output: 1331
2360-2409: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
foreachare correctly implemented.Verification successful
The
foreachfunction is only referenced within its own documentation and is not used elsewhere in the codebase.
- No additional usages of the
foreachfunction were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `foreach` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type typescript -A 5 $'foreach'Length of output: 70
Script:
#!/bin/bash # Description: Verify all function calls to `foreach` are correctly implemented. # Test: Search for the function usage in TypeScript files. rg --glob '*.ts' -A 5 $'foreach'Length of output: 1174
12557-12591: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
assert_equalare correctly implemented.
11225-11266: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
utf16idxare correctly implemented.
5778-5842: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
matchbuflineare correctly implemented.
12522-12537: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
test_garbagecollect_noware correctly implemented.
5178-5205: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
luaevalare correctly implemented.
6074-6125: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
matchstrlistare correctly implemented.Verification successful
Let's re-run the search for the
matchstrlistfunction usage with the correct parameters.
No issues found regarding the function usage.
The function
matchstrlistis currently not called anywhere else in the codebase apart from its documentation and definition.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `matchstrlist` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type typescript -A 5 $'matchstrlist'Length of output: 75
Script:
#!/bin/bash # Description: Verify all function calls to `matchstrlist` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg 'matchstrlist' -A 5Length of output: 1902
12539-12555: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
assert_beepsare correctly implemented.
5426-5467: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
maplistare correctly implemented.Verification successful
The
maplistfunction is not used elsewhere in the codebase.The function is only referenced within the
function/_generated.tsfile, primarily in comments and documentation. No further verification is required at this time.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `maplist` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type typescript -A 5 $'maplist'Length of output: 70
Script:
#!/bin/bash # Description: Verify all function calls to `maplist` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --glob '*.ts' -A 5 $'maplist'Length of output: 3394
12644-12702: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
assert_failsare correctly implemented.
12807-12889: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
assert_trueare correctly implemented.Verification successful
LGTM! But verify the function usage in the codebase.
The code changes are approved.
The
assert_truefunction is not used elsewhere in the codebase, so there are no incorrect implementations or usages to address.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `assert_true` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type typescript -A 5 $'assert_true'Length of output: 74
Script:
#!/bin/bash # Description: Verify all function calls to `assert_true` are correctly implemented. # Test: Search for the function usage in all TypeScript files. rg 'assert_true' --glob '*.ts' -A 5Length of output: 613
5469-5482: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
mapneware correctly implemented.Verification successful
No usage of
mapnewfound in the codebase.The
mapnewfunction is defined and documented correctly, but it is not currently used anywhere in the codebase. No implementation issues were found.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `mapnew` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type typescript -A 5 $'mapnew'Length of output: 69
Script:
#!/bin/bash # Description: Verify all function calls to `mapnew` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. ast-grep --lang typescript --pattern 'mapnew($_$$$)'Length of output: 54
Script:
#!/bin/bash # Description: Verify all function calls to `mapnew` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg 'mapnew'Length of output: 380
3582-3647: LGTM! But verify the function usage in the codebase.The code changes are approved.
However, ensure that all function calls to
getregionare correctly implemented.Verification successful
No issues found with the function usage in the codebase.
The
getregionfunction is newly added and there are no current usages in the codebase. Ensure to verify the function calls when the function is utilized in the future.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `getregion` are correctly implemented. # Test: Search for the function usage. Expect: Only occurrences of the new implementation. rg --type typescript -A 5 $'getregion'Length of output: 72
Script:
#!/bin/bash # Description: Verify all function calls to `getregion` are correctly implemented. # Find all TypeScript files and search for the function usage within those files. fd --type f --extension ts --exec rg 'getregion' {}Length of output: 554
Script:
#!/bin/bash # Description: Verify all function calls to `getregion` are correctly implemented. # Find all TypeScript files and search for function calls to `getregion` within those files. fd --type f --extension ts --exec rg '\bgetregion\(' {}Length of output: 316
Script:
#!/bin/bash # Description: Verify all function calls to `getregion` are correctly implemented. # Search for all occurrences of `getregion` in the codebase, regardless of file type. rg 'getregion'Length of output: 815
option/_generated.ts (3)
2282-2282: Approved: Documentation update forcommentsoption.The update clarifies the usage of the
commentsoption with comment plugins.
12792-12838: Approved: Implementation and documentation ofsmoothscrolloption.The implementation follows the existing pattern for options and includes detailed documentation. The asynchronous methods are appropriate for efficient handling of option retrieval and modification.
16343-16387: Approved: Implementation and documentation ofwinfixbufoption.The implementation follows the existing pattern for options and includes detailed documentation. The asynchronous methods are appropriate for efficient handling of option retrieval and modification.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage 81.30% 81.30%
=======================================
Files 55 55
Lines 2797 2797
Branches 228 228
=======================================
Hits 2274 2274
Misses 521 521
Partials 2 2 ☔ View full report in Codecov by Sentry. |
2 participants
Changes in 1470dcd are invalid, that version has been revised in the official version of v7.
vim-denops/denops.vim#344
This PR contains parser fixes for help format changes.
Summary by CodeRabbit
New Features
termsyncto improve terminal redraw performance.smoothscrollandwinfixbuffor enhanced scrolling and window management.Bug Fixes
Documentation