Skip to content

Use the ? operator instead of the try! macro #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

eaon
Copy link
Contributor

@eaon eaon commented Nov 21, 2018

@vhdirk
Copy link
Owner

vhdirk commented Nov 21, 2018

I didn't know ? was preferred. Thanks! Is your clippy config that strict?

@vhdirk vhdirk merged commit 121856a into vhdirk:master Nov 21, 2018
@eaon
Copy link
Contributor Author

eaon commented Nov 21, 2018

No, I guess I just learned about the language in detail after ? hit stable. I wasn't sure what try! was doing and noticed that it's not preferred anymore. There is rust-lang/rust-clippy#1361 but as the last comment suggests, occasionally there seem to be problems.

Personally I try to stay with the "modern" way of doing things with stable releases, that's all ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants