Skip to content

Conversation

sivukhin
Copy link

@sivukhin sivukhin commented Oct 3, 2025

These packages needs to be externalized to have it's wasm dependencies traced properly for node runtime so this adds it to the default list.

@ijjk ijjk added the type: next label Oct 3, 2025
@ijjk
Copy link
Member

ijjk commented Oct 3, 2025

Allow CI Workflow Run

  • approve CI run for commit: db72c96

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments:

docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx (lines 38-39):
The documentation is missing the two new Turso packages (@tursodatabase/database-wasm and @tursodatabase/sync-wasm) that were added to the server-external-packages.json file. This will cause the validation script to fail.

View Details
📝 Patch Details
diff --git a/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx b/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
index 6e83cf3b5e..78248e65c1 100644
--- a/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
+++ b/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
@@ -36,6 +36,8 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `@sparticuz/chromium`
 - `@sparticuz/chromium-min`
 - `@swc/core`
+- `@tursodatabase/database-wasm`
+- `@tursodatabase/sync-wasm`
 - `@xenova/transformers`
 - `argon2`
 - `autoprefixer`
diff --git a/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx b/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
index bff797ad9f..05fce550b7 100644
--- a/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
+++ b/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
@@ -36,6 +36,8 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
 - `@sparticuz/chromium`
 - `@sparticuz/chromium-min`
 - `@swc/core`
+- `@tursodatabase/database-wasm`
+- `@tursodatabase/sync-wasm`
 - `@xenova/transformers`
 - `argon2`
 - `autoprefixer`

Analysis

Documentation missing @tursodatabase packages causes validate-externals-doc.js to fail

What fails: The validation script scripts/validate-externals-doc.js fails because two packages in server-external-packages.json are missing from the documentation files.

How to reproduce:

node scripts/validate-externals-doc.js

Result: Script exits with code 1 and reports:

Missing packages: [
  "@tursodatabase/database-wasm",
  "@tursodatabase/sync-wasm"
]

Expected: Script should exit with code 0 and print "server externals doc is in sync"

The packages @tursodatabase/database-wasm and @tursodatabase/sync-wasm exist in packages/next/src/lib/server-external-packages.json but were missing from both docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx and docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx.

@sivukhin sivukhin force-pushed the tursodatabase-server-external branch from cc34c7f to d182a89 Compare October 3, 2025 09:18
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Oct 3, 2025
sivukhin and others added 2 commits October 3, 2025 13:35
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants