-
Notifications
You must be signed in to change notification settings - Fork 29.5k
add @tursodatabase/*-wasm packages to server-external #84485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments:
docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx (lines 38-39):
The documentation is missing the two new Turso packages (@tursodatabase/database-wasm
and @tursodatabase/sync-wasm
) that were added to the server-external-packages.json file. This will cause the validation script to fail.
View Details
📝 Patch Details
diff --git a/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx b/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
index 6e83cf3b5e..78248e65c1 100644
--- a/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
+++ b/docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
@@ -36,6 +36,8 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
- `@sparticuz/chromium`
- `@sparticuz/chromium-min`
- `@swc/core`
+- `@tursodatabase/database-wasm`
+- `@tursodatabase/sync-wasm`
- `@xenova/transformers`
- `argon2`
- `autoprefixer`
diff --git a/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx b/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
index bff797ad9f..05fce550b7 100644
--- a/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
+++ b/docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
@@ -36,6 +36,8 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne
- `@sparticuz/chromium`
- `@sparticuz/chromium-min`
- `@swc/core`
+- `@tursodatabase/database-wasm`
+- `@tursodatabase/sync-wasm`
- `@xenova/transformers`
- `argon2`
- `autoprefixer`
Analysis
Documentation missing @tursodatabase packages causes validate-externals-doc.js to fail
What fails: The validation script scripts/validate-externals-doc.js
fails because two packages in server-external-packages.json
are missing from the documentation files.
How to reproduce:
node scripts/validate-externals-doc.js
Result: Script exits with code 1 and reports:
Missing packages: [
"@tursodatabase/database-wasm",
"@tursodatabase/sync-wasm"
]
Expected: Script should exit with code 0 and print "server externals doc is in sync"
The packages @tursodatabase/database-wasm
and @tursodatabase/sync-wasm
exist in packages/next/src/lib/server-external-packages.json
but were missing from both docs/01-app/03-api-reference/05-config/01-next-config-js/serverExternalPackages.mdx
and docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
.
cc34c7f
to
d182a89
Compare
docs/02-pages/04-api-reference/04-config/01-next-config-js/serverExternalPackages.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
These packages needs to be externalized to have it's wasm dependencies traced properly for node runtime so this adds it to the default list.