Skip to content

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 29, 2025

This is causing a lot of our E2E deploy tests to fail so reverting to allow discussing/investigating separately

x-ref: https://github.com/vercel/next.js/actions/runs/18081410586
x-ref: #84216

This reverts commit 97056e0.

@ijjk ijjk enabled auto-merge (squash) September 29, 2025 17:06
@ijjk
Copy link
Member Author

ijjk commented Sep 29, 2025

Failing test suites

Commit: 32c1073 | About building and testing Next.js

pnpm test-start-experimental test/e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts(Experimental)

  • segment cache (search params) > when fetching with PPR, does not include search params in the cache key (DD)
Expand output

● segment cache (search params) › when fetching with PPR, does not include search params in the cache key

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  12 |   }
  13 |
> 14 |   it('when fetching with PPR, does not include search params in the cache key', async () => {
     |   ^
  15 |     let act: ReturnType<typeof createRouterAct>
  16 |     const browser = await next.browser('/search-params', {
  17 |       beforePageLoad(page) {

  at it (e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts:14:3)
  at Object.describe (e2e/app-dir/segment-cache/search-params/segment-cache-search-params.test.ts:5:1)

@ijjk ijjk merged commit dadfaa1 into canary Sep 29, 2025
162 of 164 checks passed
@ijjk ijjk deleted the revert/pr-84216 branch September 29, 2025 17:22
@franky47
Copy link
Contributor

I also had failures with 15.6.0-canary.{33,34} in the nuqs e2e tests, this PR solved them.

Failures were flaky (couldn't reproduce locally and failed randomly in CI), but were limited to the pages router, and exacerbated with the basePath option and/or the use of the React Compiler.

Failed runs:

lukesandberg added a commit that referenced this pull request Sep 30, 2025
…84216)"" (#84351)

Reverts #84348  which itself reverted #84216. 

In the 2nd attempt to make --turbopack a default behavior.
* adjust the Generate Pull Request States action to specify `--webpack`
* set the `IS_WEBPACK_TEST` flag in the deployment e2e tests (which are now [passing](https://github.com/vercel/next.js/actions/runs/18113062122))
* make the warning about having a webpack config without a turbopack config more verbose and consistently an error
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants