Skip to content

Conversation

p6l-richard
Copy link

For Contributors

Improving Documentation

Fixing a bug

Adding a feature

For Maintainers

  • Minimal description (aim for explaining to someone not on the team to understand the PR)
  • When linking to a Slack thread, you might want to share details of the conclusion
  • Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
  • Add review comments if necessary to explain to the reviewer the logic behind a change

What?

Updating an external link pointing to Google Tag Manager docs.

Why?

Because it's written to "refer to google tag manager docs [...] for a full list of variables", but the link pointed to is a dead-end not displaying all parameters.
I therefore updated the link to the gtag.js docs where the parameters are described.

How?

I propose to update the link in the following:
Current link:
CleanShot 2025-09-29 at 13 28 14

Proposed link:
CleanShot 2025-09-29 at 13 30 55

…er docs

The current link doesn't show a list of parameters, the new one does.
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Sep 29, 2025
@ijjk
Copy link
Member

ijjk commented Sep 29, 2025

Allow CI Workflow Run

  • approve CI run for commit: e13d330

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Sep 29, 2025

Allow CI Workflow Run

  • approve CI run for commit: 5c45e46

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants