Skip to content

Conversation

@mischnic
Copy link
Contributor

@mischnic mischnic commented Sep 16, 2025

Backport of #83745

Closes PACK-5467

Next.js tests are grouped based on timing data to better distribute them
for parallelization.

Previously this relied on a gist file that we would write to in CI.
However, this has more recently started resulting in 401s.

The actual reason for the 401s is the Turbo task wasn't propagating the
required environment variable to the task. It was mostly working by
accident, because we would store timing data on disk for the runner,
which would have been satisfied by a job that ran before it.

However despite that, relying on a gist file to read/write timing data
didn't feel like the write abstraction. I decided to refactor it to use
KV instead.

This also makes the handling more resilient to missing timing data. We
shouldn't fail the build if we can't fetch timings, as there's already
handling to fallback to round robin.
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Sep 16, 2025
@mischnic mischnic requested review from ijjk and ztanner September 16, 2025 20:41
@ijjk
Copy link
Member

ijjk commented Sep 16, 2025

Tests Passed

@mischnic mischnic merged commit c7d1855 into next-15-5 Sep 17, 2025
261 of 265 checks passed
@mischnic mischnic deleted the mischnic/backport-99e0971 branch September 17, 2025 07:35
@github-actions github-actions bot added the locked label Oct 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants