Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
8e42162
chore: upgrade express to latest version
alessandro-grosselle-adevinta Jul 12, 2025
7ca39d7
feat: implemented fix to force query to be writable
alessandro-grosselle-adevinta Jul 12, 2025
f4278f7
chore: integration test added
alessandro-grosselle-adevinta Jul 12, 2025
06358c8
chore: integration test added
alessandro-grosselle-adevinta Jul 12, 2025
765c87a
comment
alessandro-grosselle-adevinta Jul 24, 2025
bc66eec
fix: lock
alessandro-grosselle-adevinta Jul 24, 2025
2134557
fix: ts
alessandro-grosselle-adevinta Jul 24, 2025
6876868
update: lock
alessandro-grosselle-adevinta Jul 24, 2025
8826990
fix: lock
alessandro-grosselle-adevinta Jul 24, 2025
7479cb2
Update test/integration/api-resolver-query-writeable/server.js
ale-grosselle Jul 24, 2025
1dc94c3
update
alessandro-grosselle-adevinta Jul 28, 2025
906b85b
Merge branch 'canary' into express-upgrade
ale-grosselle Jul 28, 2025
3854d32
Update test/integration/api-resolver-query-writeable/server.js
ale-grosselle Jul 28, 2025
4d2c982
Merge branch 'canary' into express-upgrade
ale-grosselle Jul 28, 2025
baa505f
chore: add @types/minimatch as dev dep
alessandro-grosselle-adevinta Jul 28, 2025
c86ed63
Merge branch 'canary' into express-upgrade
alessandro-grosselle-adevinta Sep 18, 2025
ebad96c
Merge branch 'vercel:canary' into express-upgrade
ale-grosselle Oct 27, 2025
4f23b24
chore: move test
alessandro-grosselle-adevinta Oct 27, 2025
ed8d6e2
fix
alessandro-grosselle-adevinta Oct 27, 2025
e459a93
Use isolated test suite
timneutkens Oct 27, 2025
566f86a
Fix lint
timneutkens Oct 27, 2025
91cce95
Merge branch 'canary' into express-upgrade
ale-grosselle Oct 27, 2025
33d5eb8
Merge branch 'canary' into express-upgrade
ale-grosselle Oct 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/next/src/server/api-utils/node/api-resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,14 @@ export async function apiResolver(

// Parsing of cookies
setLazyProp({ req: apiReq }, 'cookies', getCookieParser(req.headers))
// Parsing query string
apiReq.query = query
// Ensure req.query is a writable, enumerable property by using Object.defineProperty.
// This addresses Express 5.x, which defines query as a getter only (read-only).
Object.defineProperty(apiReq, 'query', {
value: { ...query },
writable: true,
enumerable: true,
configurable: true,
})
// Parsing preview data
setLazyProp({ req: apiReq }, 'previewData', () =>
tryGetPreviewData(req, res, apiContext, !!apiContext.multiZoneDraftMode)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { nextTestSetup } from 'e2e-utils'

describe('api-resolver-query-writeable', () => {
const { next, skipped } = nextTestSetup({
files: __dirname,
skipDeployment: true,
startCommand: 'node server.js',
serverReadyPattern: /Next mode: (production|development)/,
dependencies: {
'get-port': '5.1.1',
express: '5.1.0',
},
})

if (skipped) {
return
}

it('should allow req.query to be writable and reflect changes made in the API handler', async () => {
const res = await next.fetch('/api?hello=yes', {
headers: {
'Content-Type': 'application/json; charset=utf-8',
},
})
if (!res.ok) {
throw new Error('Fetch failed')
}
const data = await res.json()
expect(data).toEqual({ query: { hello: 'yes', changed: 'yes' } })
})
})
4 changes: 4 additions & 0 deletions test/e2e/api-resolver-query-writeable/pages/api/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export default (req, res) => {
req.query = { ...req.query, changed: 'yes' }
res.status(200).json({ query: req.query })
}
35 changes: 35 additions & 0 deletions test/e2e/api-resolver-query-writeable/server.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
const next = require('next')
const express = require('express')

const getPort = require('get-port')

async function main() {
const dev = process.env.NEXT_TEST_MODE === 'dev'
process.env.NODE_ENV = dev ? 'development' : 'production'

const port = await getPort()
const app = next({ dev })
const handleNextRequest = app.getRequestHandler()

await app.prepare()

const server = express()

server.all('/:path', (req, res) => {
handleNextRequest(req, res)
})

server.listen(port, (err) => {
if (err) {
throw err
}

console.log(`- Local: http://localhost:${port}`)
console.log(`- Next mode: ${dev ? 'development' : process.env.NODE_ENV}`)
})
}

main().catch((err) => {
console.error(err)
process.exit(1)
})
Loading