Skip to content

[backport] Increase max cache tags to 128 #73125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijjk merged 2 commits into from
Nov 25, 2024
Merged

[backport] Increase max cache tags to 128 #73125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f7917
Increase max cache tags to 128
ijjk Nov 23, 2024
7591d3d
update test
ijjk Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/src/lib/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const NEXT_CACHE_REVALIDATE_TAG_TOKEN_HEADER =

// if these change make sure we update the related
// documentation as well
export const NEXT_CACHE_TAG_MAX_ITEMS = 64
export const NEXT_CACHE_TAG_MAX_ITEMS = 128
export const NEXT_CACHE_TAG_MAX_LENGTH = 256
export const NEXT_CACHE_SOFT_TAG_MAX_LENGTH = 1024
export const NEXT_CACHE_IMPLICIT_TAG_ID = '_N_T_'
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app-static/app-static.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('app-dir static/dynamic handling', () => {
expect(res.status).toBe(200)
await retry(() => {
expect(next.cliOutput).toContain('exceeded max tag count for')
expect(next.cliOutput).toContain('tag-65')
expect(next.cliOutput).toContain('tag-129')
})
})

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/app-dir/app-static/app/too-many-cache-tags/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export const revalidate = 0
export default async function Page() {
const tags: string[] = []

for (let i = 0; i < 96; i++) {
for (let i = 0; i < 130; i++) {
tags.push(`tag-${i}`)
}
const data = await fetch(
Expand Down
Loading